From owner-svn-src-head@freebsd.org Thu May 18 17:19:35 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2406DD73779 for ; Thu, 18 May 2017 17:19:35 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E945410A2 for ; Thu, 18 May 2017 17:19:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x234.google.com with SMTP id o5so104366754ith.1 for ; Thu, 18 May 2017 10:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=aD0mN/W7FjdAduIvmpZtp/CryPe018KeHZVUyMfG8CM=; b=erZdMXQEcbGc0VowIEtTM1dSL4NnLfmXiKwW6d/ZiGpafOz8x/+/I1RW3i/jX1rIgU S7ZQ1NiXKcpQsoLQiQ9oAkHEyQolpgN0aorzWJkmBuEPCeUFBC9UlsQqNPmYwZiN50BL YSCGbU4at3rR93Vu34XbSKyIOJ1cSz6B1tA77aHxUXNely3je2t8DJykhBukTILvg8bY Urfzo9oQyEXCtCGhRKDbE2KfNVbgj15Qvhz4Vz5Q2lml52Jjh8+KACuek0FS2WcbDp0i MRDqMcMerIRC04GTWYdZQhgAKchL8ALIgzSU9uU5Lsb7EDGiWv8AZEYJho57wUmKRnOk qEJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=aD0mN/W7FjdAduIvmpZtp/CryPe018KeHZVUyMfG8CM=; b=OdvOLsJBzBuB6KNGWSS/SsUvpYzJZPq3lQSnxfyuxl+YQMsr13WnJ4qZtG5GsHXgFD r9fgYWAB/JtU1g/mNjYTAHEqvBJuyEtLU5BYg03jNp06w/chVvP3Cb30lQmEwYm0MNLl ifHkl7L3iucRDXCUPxGisVCbw1IKtNQulGREb1MpdnjG90Z12ngvlg4heKmrfmr6ECPE njIUd3CA4vvRc3SWMgq0eYoNt/d9iC6bCCJIEaLbMoANejuixD/GTtCaIykHejYbQIYc FFU+i2LVYQ4e0D8N/EJsQleK+gaNziJPEX/Uqbq6GhnB+Q58nvY1D8PnlohkZAI07ZGn zUQA== X-Gm-Message-State: AODbwcA7SVTyNLSawrmTTUDqTh1acucEO3j1bakIIwQgGlmUWVxD4JRT 8mlUjvWrfPdIv1faHqizBqo3Slb7dwZN X-Received: by 10.36.44.14 with SMTP id i14mr24386705iti.103.1495127974032; Thu, 18 May 2017 10:19:34 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.126.6 with HTTP; Thu, 18 May 2017 10:19:33 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:cdd4:9b25:be09:9f7d] In-Reply-To: <201705180956.v4I9uVpQ065465@pdx.rh.CN85.dnsmgr.net> References: <201705180625.v4I6Pd9j062495@repo.freebsd.org> <201705180956.v4I9uVpQ065465@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Thu, 18 May 2017 11:19:33 -0600 X-Google-Sender-Auth: NsXvlxGjrESXeo6L3QrPY1n4KQ8 Message-ID: Subject: Re: svn commit: r318441 - in head/etc: . cron.d To: "Rodney W. Grimes" Cc: Ngie Cooper , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2017 17:19:35 -0000 On Thu, May 18, 2017 at 3:56 AM, Rodney W. Grimes wrote: >> Author: ngie >> Date: Thu May 18 06:25:39 2017 >> New Revision: 318441 >> URL: https://svnweb.freebsd.org/changeset/base/318441 >> >> Log: >> Handle the cron.d entry for MK_AT in cron conditionally >> >> Install /etc/cron.d/at if MK_AT != no, always using it, which tries >> to run a non-existent program via cron(8) every 5 minutes with the >> default /etc/crontab, prior to this commit. >> >> SHELL and PATH are duplicated between /etc/crontab and /etc/cron.d/at >> because atrun(8) executes programs, which may rely on environment >> currently set via /etc/crontab. >> >> Noted by: bdrewery (in an internal review) >> MFC after: 2 months >> Relnotes: yes (may need to add environmental modifications to >> /etc/cron.d/at) >> Sponsored by: Dell EMC Isilon >> >> Added: >> head/etc/cron.d/ >> head/etc/cron.d/Makefile (contents, props changed) >> head/etc/cron.d/at (contents, props changed) >> Modified: >> head/etc/Makefile >> head/etc/crontab >> >> Modified: head/etc/Makefile >> ============================================================================== >> --- head/etc/Makefile Thu May 18 06:15:42 2017 (r318440) >> +++ head/etc/Makefile Thu May 18 06:25:39 2017 (r318441) >> @@ -8,6 +8,7 @@ FILESGROUPS= FILES >> # No need as it is empty and just causes rebuilds since this file does so much. >> UPDATE_DEPENDFILE= no >> SUBDIR= \ >> + cron.d \ >> newsyslog.conf.d \ >> syslog.d > > The thread on the newsyslog clearly shows that this is a contriversial change. > > I strongly object to further splitting of /etc/FOO into /etc/foo.d/FOO files > to suite Dell/EMC/Isilon's needs. It is in conflict with the needs and > desires of others. > > I especially object to it being done on a 1 of case, either completly split > the file or make it 1 file, but making it this miss match is just adding to > the work load of ansible and puppet task writting. You now have to mange > 2 config files rather than 1 for cron, and 7 for newsyslog instead of 1. In the vast majority of the cases so far, I'm convinced the changes are for the better and will make things like mergemaster / etcupate / etc easier on our users. Since the files are separate, and you almost never touch them, it's a net win. Consider this a strong encouragement to proceed. Warner >> Added: head/etc/cron.d/Makefile >> ============================================================================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/etc/cron.d/Makefile Thu May 18 06:25:39 2017 (r318441) >> @@ -0,0 +1,11 @@ >> +# $FreeBSD$ >> + >> +.include >> + >> +.if ${MK_AT} != "no" >> +FILES+= at >> +.endif >> + >> +BINDIR= /etc/cron.d >> + >> +.include >> >> Added: head/etc/cron.d/at >> ============================================================================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/etc/cron.d/at Thu May 18 06:25:39 2017 (r318441) >> @@ -0,0 +1,7 @@ >> +# $FreeBSD$ >> +# >> +SHELL=/bin/sh >> +PATH=/etc:/bin:/sbin:/usr/bin:/usr/sbin >> + >> +# See crontab(5) for field format. >> +*/5 * * * * root /usr/libexec/atrun >> >> Modified: head/etc/crontab >> ============================================================================== >> --- head/etc/crontab Thu May 18 06:15:42 2017 (r318440) >> +++ head/etc/crontab Thu May 18 06:25:39 2017 (r318441) >> @@ -7,8 +7,6 @@ PATH=/etc:/bin:/sbin:/usr/bin:/usr/sbin >> # >> #minute hour mday month wday who command >> # >> -*/5 * * * * root /usr/libexec/atrun >> -# >> # Save some entropy so that /dev/random can re-seed on boot. >> */11 * * * * operator /usr/libexec/save-entropy >> # >> >> > > -- > Rod Grimes rgrimes@freebsd.org >