From owner-svn-src-all@FreeBSD.ORG  Wed Oct 16 19:47:15 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 3B4A08BD;
 Wed, 16 Oct 2013 19:47:15 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-qe0-x22e.google.com (mail-qe0-x22e.google.com
 [IPv6:2607:f8b0:400d:c02::22e])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id BA7E02636;
 Wed, 16 Oct 2013 19:47:14 +0000 (UTC)
Received: by mail-qe0-f46.google.com with SMTP id s14so1052766qeb.19
 for <multiple recipients>; Wed, 16 Oct 2013 12:47:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=l7j55qsIwJWtPvtzRzb/pbT7YrdBxklg/Wsse+wkTlM=;
 b=lrB2+F3Yhptj2ebCb6eYOtznfsFMnb8TWID/vTDiclC8eweGZ1eNpNW8/dwzQ5e+Re
 8W2Qq5hYUPB0uLIDBoMHSmEzytA31Othnzd54NxGcIm0rDOSaBY3FGkxKAmOb4nSYbTj
 mAPEeItdKsvoDrm0HQEuzFjKDNbCVOd1JoSQEKHEpD2AdQoBMW38fDsoYu7MfyVqkC9+
 Tc/tpDxVM2NAank/rU6bdrmdBHAkw9leS4+dR/EATcNehAkdivGkE42mNWG2iuS5zkWe
 ILXRBY3ZuQJjqkhatpbpJYrw9nloqgYDBgsOGmE98UjPc0rygbCO5bYnW+G0R8+GgYOs
 24pA==
MIME-Version: 1.0
X-Received: by 10.224.157.14 with SMTP id z14mr7211141qaw.90.1381952833693;
 Wed, 16 Oct 2013 12:47:13 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.224.207.66 with HTTP; Wed, 16 Oct 2013 12:47:13 -0700 (PDT)
In-Reply-To: <201310160502.r9G521cA066218@svn.freebsd.org>
References: <201310160502.r9G521cA066218@svn.freebsd.org>
Date: Wed, 16 Oct 2013 12:47:13 -0700
X-Google-Sender-Auth: wI6x0SEKC434KTt89yQQTGXAPKQ
Message-ID: <CAJ-VmokmOfMue6t82iAqo6UDxbQCF7wx_yyEKwZVQo-ewSyQEA@mail.gmail.com>
Subject: Re: svn commit: r256587 - in head/sys: kern sys
From: Adrian Chadd <adrian@freebsd.org>
To: Gleb Smirnoff <glebius@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Oct 2013 19:47:15 -0000

.. so what brought this on? I can see this fixing issues for things where a
virtual device is created with taskqueues (eg a tap device of some sort)
that get stuffed into a vnet context. But for physical interfaces whose
taskqueues don't have a specific vnet context and may need to set it
per-packet, what may this break?

Ie - what did this fix, and why isn't it being fixed in all the various
taskqueues in device drivers?

I'd rather not see the taskqueue setup (which knows nothing about network
contexts at all) grow this just to solve a bunch of places where the task
in question can just correctly initialise the context itself when it's
called.

Thanks,



-adrian