From owner-freebsd-current  Fri Jan 21  4:17:53 2000
Delivered-To: freebsd-current@freebsd.org
Received: from inetfw.sonycsl.co.jp (inetfw.SonyCSL.Co.Jp [203.137.129.4])
	by hub.freebsd.org (Postfix) with ESMTP id 5867E14C33
	for <current@freebsd.org>; Fri, 21 Jan 2000 04:17:51 -0800 (PST)
	(envelope-from kjc@csl.sony.co.jp)
Received: from hotaka.csl.sony.co.jp (root@hotaka.csl.sony.co.jp [43.27.98.57])
	by inetfw.sonycsl.co.jp (8.9.3+3.2W/3.7Ws3/99071615/smtpfeed 1.01) with ESMTP id VAA94287;
	Fri, 21 Jan 2000 21:17:50 +0900 (JST)
Received: from localhost (kjc@[127.0.0.1])
	by hotaka.csl.sony.co.jp (8.8.8/3.7Ws3/hotaka/99101212) with ESMTP id VAA23338;
	Fri, 21 Jan 2000 21:17:49 +0900 (JST)
To: current@freebsd.org
Cc: Yoichi Shinoda <shinoda@jaist.ac.jp>
Subject: pci_write_config arg order
X-Mailer: Mew version 1.95b3 on Emacs 20.5 / Mule 4.0 (HANANOEN)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20000121211748V.kjc@csl.sony.co.jp>
Date: Fri, 21 Jan 2000 21:17:48 +0900
From: Kenjiro Cho <kjc@csl.sony.co.jp>
X-Dispatcher: imput version 991025(IM133)
Lines: 17
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


pci_write_config() and pci_cfgwrite() defined in sys/pci/pcivar.h 
have an unusual argument order:

	pci_read_config(dev, reg, width)
	pci_write_config(dev, reg, val, width)

	pci_cfgread(cfg, offset, size)
	pci_cfgwrite(cfg, offset, val, size)

Apparently, pcisupport.c and isp_pci.c misplace the 3rd and 4th args.

Could someone take a look?

Reported by Yoichi Shinoda <shinoda@jaist.ac.jp>

-Kenjiro


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message