From owner-freebsd-bugs@FreeBSD.ORG Wed Oct 18 20:20:27 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A3B1816A4D4 for ; Wed, 18 Oct 2006 20:20:27 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DAD343D55 for ; Wed, 18 Oct 2006 20:20:27 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9IKKRMN045805 for ; Wed, 18 Oct 2006 20:20:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9IKKRJT045804; Wed, 18 Oct 2006 20:20:27 GMT (envelope-from gnats) Date: Wed, 18 Oct 2006 20:20:27 GMT Message-Id: <200610182020.k9IKKRJT045804@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Lowell Gilbert Cc: Subject: Re: kern/86965: [ntfs] NTFS driver returns incorrect 'number of links' for directories X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Lowell Gilbert List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2006 20:20:27 -0000 The following reply was made to PR kern/86965; it has been noted by GNATS. From: Lowell Gilbert To: bug-followup@FreeBSD.org,cryptographite@comcast.net Cc: Subject: Re: kern/86965: [ntfs] NTFS driver returns incorrect 'number of links' for directories Date: Wed, 18 Oct 2006 16:15:10 -0400 I prefer (and have successfully used) the following patch (against RELENG_6): --- /usr/src/sys/fs/ntfs/ntfs_vnops.c.ORIG Wed Oct 18 13:43:06 2006 +++ /usr/src/sys/fs/ntfs/ntfs_vnops.c Wed Oct 18 15:11:51 2006 @@ -187,8 +187,11 @@ vap->va_fsid = dev2udev(ip->i_dev); vap->va_fileid = ip->i_number; vap->va_mode = ip->i_mp->ntm_mode; vap->va_nlink = ip->i_nlink; + /* fake a link count if we don't know the real one */ + if ((vap->va_nlink == 0) && !(ip->i_flag & IN_LOADED)) + vap->va_nlink = 1; vap->va_uid = ip->i_mp->ntm_uid; vap->va_gid = ip->i_mp->ntm_gid; vap->va_rdev = 0; /* XXX UNODEV ? */ vap->va_size = fp->f_size;