From owner-cvs-src@FreeBSD.ORG  Fri Mar 11 17:35:34 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4F84416A4CE; Fri, 11 Mar 2005 17:35:34 +0000 (GMT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 129B143D58; Fri, 11 Mar 2005 17:35:34 +0000 (GMT)
	(envelope-from sam@errno.com)
Received: from [66.127.85.91] (sam@[66.127.85.91])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j2BHZWms072773
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 11 Mar 2005 09:35:32 -0800 (PST)
	(envelope-from sam@errno.com)
Message-ID: <4231D748.4080405@errno.com>
Date: Fri, 11 Mar 2005 09:37:12 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041208)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Hajimu UMEMOTO <ume@FreeBSD.org>
References: <200503111626.j2BGQAvL012546@repoman.freebsd.org>
In-Reply-To: <200503111626.j2BGQAvL012546@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/crypto/rijndael rijndael-alg-fst.c
 rijndael-alg-fst.h
 rijndael-api-fst.c rijndael-api-fst.h rijndael.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2005 17:35:34 -0000

Hajimu UMEMOTO wrote:
> ume         2005-03-11 16:26:10 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/crypto/rijndael  rijndael-alg-fst.c rijndael-api-fst.c 
>                          rijndael-api-fst.h rijndael.h 
>   Removed files:
>     sys/crypto/rijndael  rijndael-alg-fst.h 
>   Log:
>   integrate rijndael-alg-fst.h into rijndael.h.

Why did you make this change and others before I could respond?  I told 
you I agreed with your overall goal but that there were specific isuses 
we needed to resolve before you pulled the trigger.  Less than 24 hours 
after your last note to me you committed the changes.

This change in particular I'm not happy with because--as I explained to 
you--I am uncertain if there are user applications that include files 
from /usr/include/crypto that may be affected.

As we discussed privately there is no immediate benefit to what you are 
doing.  In fact because of these changes we are diverging from BOTH kame 
and openbsd code bases.  I'm willing to do that but only after 
understanding the consequences.

	Sam