From owner-cvs-all@FreeBSD.ORG  Sun Mar 30 12:09:54 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A995D37B401; Sun, 30 Mar 2003 12:09:54 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 901A943FAF; Sun, 30 Mar 2003 12:09:53 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.8/8.12.8) with ESMTP id h2UK9oSM017379;
	Sun, 30 Mar 2003 22:09:50 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: Nate Lawson <nate@root.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 30 Mar 2003 12:05:05 -0800."
             <Pine.BSF.4.21.0303301153000.5939-100000@root.org> 
Date: Sun, 30 Mar 2003 22:09:50 +0200
Message-ID: <17378.1049054990@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/fdisk fdisk.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Mar 2003 20:09:57 -0000

In message <Pine.BSF.4.21.0303301153000.5939-100000@root.org>, Nate Lawson writ
es:
>On Sat, 29 Mar 2003, Poul-Henning Kamp wrote:
>> In message <Pine.BSF.4.21.0303291408451.4536-100000@root.org>, Nate Lawson writ
>> es:
>> >On Sat, 29 Mar 2003, Poul-Henning Kamp wrote:
>> >>   Modified files:
>> >>     sbin/fdisk           fdisk.c 
>> >>   Log:
>> >>   Use default geometry in case the device doesn't provide one:
>> >>           512 for sectorsize.
>> >>           63 for sectors.
>> >>           255 for heads.
>> >>   This will mostly show up on MD(4) devices.
>> >
>> >Won't this be a problem for small devices or for int 13 booting?  That's
>> >why we use 64 heads, 32 sectors for scsi devices < 1 GB.
>> 
>> You can specify any number you like to fdisk using all the usual
>> ways of doing so, and you should if you want to copy the image to
>> some other media afterwards.
>
>Sure.  My concern was for devices like USB flash disks where your defaults
>may not be appropriate and the info IS being written to media.  Would you
>be willing to put in a < 1GB size check on the media to use more
>appropriate heads/sector values?

USB flash disks will report with DIOCGFWSECTORS/FWHEADS and therefore
not hit this code.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.