Date: Fri, 3 Feb 2023 12:07:54 +0100 From: Moin Rahman <bofh@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org>, Matthias Fechner <mfechner@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8607332fb826 - main - www/gitlab-pages: Fix bulk build warning Message-ID: <CFBB1923-9D8C-40A4-9F47-60C2939EF668@freebsd.org> In-Reply-To: <20230203091258.5ou4dpzklcp7euqj@aching.in.mat.cc> References: <202302022304.312N4C2R091641@gitrepo.freebsd.org> <20230203091258.5ou4dpzklcp7euqj@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_00CEED59-A239-44E6-BAAF-2323FFBDED27 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Feb 3, 2023, at 10:12 AM, Mathieu Arnold <mat@FreeBSD.org> wrote: >=20 > On Thu, Feb 02, 2023 at 11:04:12PM +0000, Muhammad Moinur Rahman = wrote: >> The branch main has been updated by bofh: >>=20 >> URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D8607332fb8268becd08f7e6cfbc853= bc76e2cc43 >>=20 >> commit 8607332fb8268becd08f7e6cfbc853bc76e2cc43 >> Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> >> AuthorDate: 2023-02-02 23:01:36 +0000 >> Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> >> CommitDate: 2023-02-02 23:01:36 +0000 >>=20 >> www/gitlab-pages: Fix bulk build warning >>=20 >> In the previous commit a duplicate USE_FETCH target was added = similar to >> the one in Mk/Uses/go.mk. However this is possible using a = different >> number and target name compared to what is already predefined as = it >> conflicts. >=20 > I fail to see the functional difference between this target and the > existing one in USES=3Dgo, and it feels that now, the fetch is done = twice, > once in USES=3Dgo and once here. I didn't say that it solves the actual problem entirely but it at least = fixes the warning in the bulk build. > Can you try to see if it still works without this target here? I am not an expert in the gitlab stuffs done in the ports tree. Looping in mfechner@ who made the original commit. >> Reported by: bulk build >> Approved by: portmgr (just-fix-it) >> --- >> www/gitlab-pages/Makefile | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >>=20 >> diff --git a/www/gitlab-pages/Makefile b/www/gitlab-pages/Makefile >> index 9a97306037d6..da241eeec460 100644 >> --- a/www/gitlab-pages/Makefile >> +++ b/www/gitlab-pages/Makefile >> @@ -1,5 +1,6 @@ >> PORTNAME=3D gitlab-pages >> PORTVERSION=3D 15.8.1 >> +PORTREVISION=3D 1 >> DISTVERSIONPREFIX=3D v >> CATEGORIES=3D www >>=20 >> @@ -29,8 +30,8 @@ MASTER_SITES+=3D = https://gitlab.com/gitlab-org/gitlab-pages/-/raw/v${DISTVERSION}/ >> DISTFILES+=3D go.mod >> DIST_SUBDIR=3D go/${PKGORIGIN:S,/,_,g}/${DISTNAME} >> EXTRACT_ONLY+=3D ${DISTFILES:N*.mod\:*:N*.mod:C/:.*//} >> -_USES_fetch+=3D 800:go-post-fetch >> -go-post-fetch: >> +_USES_fetch+=3D 900:go-post-fetch-gitlab >> +go-post-fetch-gitlab: >> @${ECHO_MSG} "=3D=3D=3D> Fetching ${PORTNAME} dependencies"; >> @(cd ${DISTDIR}/${DIST_SUBDIR}; \ >> [ -e go.mod ] || ${RLN} ${GO_MODFILE} go.mod; \ >>=20 >=20 > -- > Mathieu Arnold --Apple-Mail=_00CEED59-A239-44E6-BAAF-2323FFBDED27 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmPc6wpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA vJF8mw//Z5e2q9ftgafTjHiBG3pT0eNPW1qZGfF0VKGbRY/WDzi5EtHJY4L8Mbeq cR+w0HAQTAx2W+TLWY6nmEwQ3Ak/RUdStOWkb5NFI5H7U2ki8+BkV3Cp/zoRJVZU kyMSekTJ1hQA5xold7MIxZT2IcMY+9d3jdrIbcbM1iiIlrA82hLkIRm3Kc01214J YfCrMEJuq/XWhOdL656pyPRa+yQVL/FXaFDQFhRtfJKNHsgUchovomMABLaYYZOi yQd39KYcutzFm6NPZy32lFbgbkj4kMiP3MoK4R8hKUwsn0uIot4pHRndp6s+MECP WTvH2JgSlORKwlWeOI8596/F7tVJs/OE6zzNMiLcbtRJ9eY95B0N+o/owoqxEnDB oDh4jjthYANPz5Dlt//gekHn2+FSHud+zfZX4TwQaB8IINhptTu7sWPrn+TU9P73 L1mdhEusP3bwHFwUQttlf6EC5+lu67DZJyN8J8egwpQ/yPlAxxJi+vyBriFnJNJi zm+zC1tuSnOH2iIEHdJYfWW5XhGpOHR0dEHE90sZEyhbszWx4jAHHp7FSllPw/8z J7HecA7kDZCjjBQzmfMGiw+Z1XQVJQRpeYKdNfPLuYKlJ1ujma2NKhUfEjrrPLYl cCRleopan3mZn8niD29hwbdGEN9LYbLH9/aTRMinVJWvKbUApSE= =odAU -----END PGP SIGNATURE----- --Apple-Mail=_00CEED59-A239-44E6-BAAF-2323FFBDED27--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CFBB1923-9D8C-40A4-9F47-60C2939EF668>