From owner-svn-src-head@freebsd.org Tue Nov 10 15:03:31 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE674A2A5A9 for ; Tue, 10 Nov 2015 15:03:31 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pa0-x22e.google.com (mail-pa0-x22e.google.com [IPv6:2607:f8b0:400e:c03::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B88E713B5 for ; Tue, 10 Nov 2015 15:03:31 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by pacdm15 with SMTP id dm15so212484954pac.3 for ; Tue, 10 Nov 2015 07:03:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=pBrtqoz9QurPabOEbEvEbi6nOkFpJYvQQ0NDVzmtlkA=; b=k4BnB36BYcHVo4cEL1kDjMuqdohy1YmzeFVDz6JBFmJ4pP1Z0DDAgX1P3iN8kiaKar ivhPhNXupwOtMT2gVpKZQzPMEg2auFpcE1x7jeQ04wU1JpMKTr3d6V1SnMcyi8ffqH5W GbI4LpCWUB2+xb9PkSCbEA4FinuQQ41RjCFV0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=pBrtqoz9QurPabOEbEvEbi6nOkFpJYvQQ0NDVzmtlkA=; b=DVl7AqxguffrKd2takq1xxlcLvsjINft9q5aHL55BtK7JusG0XPGhzLgbmTa7VphQ7 /4CeBFMmj86gXtkt3ToC9sbrG4cC5DOXEyyewHITPjj+KYXbWO8r+zlPI3Ar6iU5kl5N 44wH7d9Q6poSV/lsS4o2T15+De+aY0+FY+TfJtJjaHBh8sdtfR7zuD+Cusl8Dq8FIK6q a8O0RZ44vSYhmvoubAZx7w5M4NntR0npVc7Xw4BHY5ZdVaNKFUx5ObQ+AvTNsLdEKITj ic287Jz3sybIMzuNd2fCVvMf4O5+7Gpa61kwF1BFoUTpkOVdhQYEA0nETiWQF3obD2dC Gmkw== X-Gm-Message-State: ALoCoQk+ERSTfiluuvwTWax36tsFH/GEkgCvR73qY0nu0f+aoyuRzF2loExyWruH4NwWM7ulCw3k X-Received: by 10.66.193.38 with SMTP id hl6mr6440298pac.85.1447167809993; Tue, 10 Nov 2015 07:03:29 -0800 (PST) Received: from [100.127.144.199] ([69.53.245.39]) by smtp.gmail.com with ESMTPSA id d13sm4629012pbu.20.2015.11.10.07.03.28 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Nov 2015 07:03:29 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys From: Randall Stewart In-Reply-To: <56420634.5060704@selasky.org> Date: Tue, 10 Nov 2015 10:03:28 -0500 Cc: Randall Ray Stewart , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <19671573-5C8C-4E33-845B-791DA966E4A9@netflix.com> References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <56420634.5060704@selasky.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 15:03:32 -0000 And I disagree here Hans You don=92t need that and it just adds more into the callout system that is not needed. R On Nov 10, 2015, at 9:59 AM, Hans Petter Selasky = wrote: > On 11/10/15 15:49, Randall Stewart wrote: >> +#define callout_async_drain(c, d) = \ >> + _callout_stop_safe(c, 0, d) >=20 > Hi, >=20 > Like commented in D4076, I think the callout_async_drain() function = should take a second void pointer argument, which is passed to the drain = function, instead of re-using the pointer argument passed to = callout_reset(), because that will make many to one, N:1, asynchronous = drain possible. >=20 > --HPS -------- Randall Stewart rrs@netflix.com 803-317-4952