From owner-cvs-src-old@FreeBSD.ORG Sun Nov 21 14:34:49 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3D251065673 for ; Sun, 21 Nov 2010 14:34:49 +0000 (UTC) (envelope-from brucec@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 91C538FC13 for ; Sun, 21 Nov 2010 14:34:49 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id oALEYnJb041964 for ; Sun, 21 Nov 2010 14:34:49 GMT (envelope-from brucec@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id oALEYnqs041963 for cvs-src-old@freebsd.org; Sun, 21 Nov 2010 14:34:49 GMT (envelope-from brucec@repoman.freebsd.org) Message-Id: <201011211434.oALEYnqs041963@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to brucec@repoman.freebsd.org using -f From: Bruce Cran Date: Sun, 21 Nov 2010 14:34:25 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/sysinstall dispatch.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2010 14:34:49 -0000 brucec 2010-11-21 14:34:25 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall dispatch.c Log: SVN rev 215637 on 2010-11-21 14:34:25Z by brucec dispatch_add_command: Modify the logic so there's only one exit point instead of two. Only insert valid (non-NULL) values into the queue. dispatch_free_command: Ensure that item is not NULL before removing it from the queue and dereferencing the pointer. NULL out free'd pointers to catch any use-after-free bugs. PR: bin/146855 Submitted by: gcooper MFC after: 3 days Revision Changes Path 1.56 +23 -9 src/usr.sbin/sysinstall/dispatch.c