From owner-svn-src-head@freebsd.org Fri Jul 10 17:24:40 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6A7E336EAF2; Fri, 10 Jul 2020 17:24:40 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B3Kfc0pRzz4sXV; Fri, 10 Jul 2020 17:24:39 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from lrrr.mouf.net (cpe-76-182-16-135.nc.res.rr.com [76.182.16.135]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id 06AHOKG9099205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 10 Jul 2020 17:24:26 GMT (envelope-from swills@FreeBSD.org) Subject: Re: svn commit: r352558 - head/usr.bin/top To: Mark Millard , "daichi@freebsd.org" , svn-src-head@freebsd.org, FreeBSD Current , Hiroki Sato References: <1BDFB387-930D-4F4D-8729-A5850F1C15B9.ref@yahoo.com> <1BDFB387-930D-4F4D-8729-A5850F1C15B9@yahoo.com> From: Steve Wills Message-ID: <61107ecc-6f9b-a4db-7b1e-ec75f73939ee@FreeBSD.org> Date: Fri, 10 Jul 2020 13:24:16 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1BDFB387-930D-4F4D-8729-A5850F1C15B9@yahoo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Fri, 10 Jul 2020 17:24:28 +0000 (UTC) X-Spam-Status: No, score=0.3 required=4.5 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-Rspamd-Queue-Id: 4B3Kfc0pRzz4sXV X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; ASN(0.00)[asn:36236, ipnet:2607:fc50::/36, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 17:24:40 -0000 On 11/28/19 4:08 PM, Mark Millard via svn-src-head wrote: >> Author: daichi >> Date: Fri Sep 20 17:37:23 2019 >> New Revision: 352558 >> URL: >> https://svnweb.freebsd.org/changeset/base/352558 >> >> >> Log: >> top(1): support multibyte characters in command names (ARGV array) >> depending on locale. >> >> - add setlocale() >> - remove printable() function >> - add VIS_OCTAL and VIS_SAFE to the flag of strvisx() to display >> non-printable characters that do not use C-style backslash sequences >> in three digit octal sequence, or remove it >> >> This change allows multibyte characters to be displayed according to >> locale. If it is recognized as a non-display character according to the >> locale, it is displayed in three digit octal sequence. >> > > Initially picking on tab characters as an example of what is > probably a somewhat broader issue . . . > > Ever since this change, characters like tabs that do not fit > in the next character cell when output, but for which they > are !isprintable(...), now mess up the top display. Again > using tab as an example: line wrapping from the text having > been shifted over by more than one character cell. top does > not track the line wrapping result in how it decides what > to output for the following display updates. > Apologies for the way late reply here, but I just now bothered tracking this down. This commit seems to be the cause of some corruption I'm seeing in long running top(1) as well. As Mark mentions, if I use "hh" it clears up. Should I open a bugzilla bug? I can share screenshots of the corruption, such as: https://i.imgur.com/Xqlwf9h.png https://i.imgur.com/Jv0d5NU.png Thanks, Steve