From owner-freebsd-stable@FreeBSD.ORG Wed Feb 17 11:18:16 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE11E106566C for ; Wed, 17 Feb 2010 11:18:16 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iw0-f175.google.com (mail-iw0-f175.google.com [209.85.223.175]) by mx1.freebsd.org (Postfix) with ESMTP id 8278C8FC13 for ; Wed, 17 Feb 2010 11:18:16 +0000 (UTC) Received: by iwn5 with SMTP id 5so3165431iwn.9 for ; Wed, 17 Feb 2010 03:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:cc :subject:in-reply-to:message-id:references:user-agent :x-openpgp-key-id:x-openpgp-key-fingerprint:mime-version :content-type; bh=HFTegxz9fgJ/mqz8XE2bsRQYl6DgkzFEYPRq7FFUVBA=; b=Yhu7NDgAXkr2gGZJ5F3yojZRG8BMNZmZJyaGBINk9VX6prxT8nO7evneQhw5n3AHjo K9e3DKgVhr1nOB4za5MSMkmvtcedYvh/FPHMTzBjoaKMwPdJVEsIGcLmRTqeuYegLK3A aI4QWixIULHREWlfkU8H+L9Dt3xoytNeKFSeA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:x-openpgp-key-id:x-openpgp-key-fingerprint:mime-version :content-type; b=C0OXmc0VVVJ1of6tIUODR2w5JztV7Qcfxekzghz1e4p/ChZ5UkwaaDH34Ty00GGwSQ ENhNsQx6cf2iQu6roi3Hb+RP8Ke20uy4f5Xp5AsyweH8a5LdyXDDgC5ImEUbIUl6koPX /vLObUeXGp78k/kUuJGIC5KPcP1kR8Y0UB04Y= Received: by 10.231.145.196 with SMTP id e4mr3968772ibv.54.1266405495812; Wed, 17 Feb 2010 03:18:15 -0800 (PST) Received: from centel.dataix.local (ppp-21.195.dialinfree.com [209.172.21.195]) by mx.google.com with ESMTPS id 20sm1929715iwn.1.2010.02.17.03.18.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 17 Feb 2010 03:18:14 -0800 (PST) Sender: "J. Hellenthal" Date: Wed, 17 Feb 2010 06:18:01 -0500 From: jhell To: Bartosz Stec In-Reply-To: Message-ID: References: <20100215090756.GA54764@icarus.home.lan> <20100215105000.101326yj01j0f64g@webmail.leidinger.net> <20100215122744.GA57382@icarus.home.lan> <20100215161105.14071eiflhc9le68@webmail.leidinger.net> <4B79BA9C.3020402@quip.cz> <4B7AD0A3.9080701@barryp.org> <20100216175946.GA98082@icarus.home.lan> <20100216200511.GA95812@server.vk2pj.dyndns.org> <20100216215637.GA4299@icarus.home.lan> <4B7BA6A5.9020306@it4pro.pl> <20100217093237.fe4b4e14.torfinn.ingolfsen@broadpark.no> <4B7BAF59.7040407@it4pro.pl> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: FreeBSD Stable Subject: Re: ZFS tuning [was: hardware for home use large storage] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2010 11:18:16 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Wed, 17 Feb 2010 04:53, jhell@ wrote: > ---------------------------- PGP Command Output ---------------------------- > gpg: Signature made Wed Feb 17 04:53:27 2010 EST using RSA key ID 89D8547E > gpg: Good signature from "jhell " > ----------- Begin PGP Signed Message Verified 2010-02-17 06:13:53 ---------- > > > > On Wed, 17 Feb 2010 03:56, bartosz.stec@ wrote: >> On 2010-02-17 09:32, Torfinn Ingolfsen wrote: >>> On Wed, 17 Feb 2010 09:19:49 +0100 >>> Bartosz Stec wrote: >>> >>> >>>> So here's my reply (last line seems most interesting ;) : >>>> >>> [...snipped...] >>> >>>> Illegal division by zero at ./arc_summary.pl line 242. >>>> >>> FWIW, I also got this line when I ran this script on my idle zfs server. >>> >> I'm not a PERL programmer (or programmer at all ;), but what I see is >> script >> doesn't check if L2ARC is used at all, so it will always try compute these >> lines: >> >> printf("\tL2 Hit Ratio:\t\t\t%0.2f%%\t%d\n", 100 * ( $l2_hits / ( $l2_hits >> + >> $l2_misses )), $l2_hits ); >> printf("\tL2 Miss Ratio:\t\t\t%0.2f%%\t%d\n", 100 * ( $l2_misses / ( >> $l2_hits >> + $l2_misses )), $l2_misses ); >> printf("\tL2 Feeds Ratio:\t\t\t%0.2f%%\t%d\n", 100 * ( $l2_feeds / ( >> $l2_hits >> + $l2_misses )), $l2_feeds ); >> >> Without active L2ARC it will always generate divide at zeo error, so it >> seems >> that additional check for usable L2ARC values is needed at first place. >> >> > > Thanks for reporting this. As I am usually on a system that is using a > L2ARC I wouldn't have noticed it. > > I should have this fixed in about 10 hours. But as I am writing this email > I am heading off to bed, work calls in the morning. > > Check back tomorrow night for a updated version and adjust the current to > your liking for the moment. > > ;) Thanks again. > > -- > > jhell > > > ------------ End PGP Signed Message Verified 2010-02-17 06:13:53 ----------- > I take that back. I just uploaded a modified version that I wrapped with a if statement to check and see if l2_hits >= 0. If you don't have a L2ARC you will now get a message explaining why its not included in your summary. I couldn't sleep until I fixed this knowing that more people are probably going to come across this problem and email back. New rev: 184 MD5 (arc_summary.pl) = f47bac165e7bf707d5f81cfdd007c30a SHA256 (arc_summary.pl) = 794dce069ff649598d99204b362d141a19da47dcf60ec165b260d55a5c9d493f SIZE (arc_summary.pl) = 12695 http://jhell.googlecode.com/files/arc_summary.pl http://jhell.googlecode.com/files/arc_summary.pl.asc Now I can finally sleep ;) - -- jhell -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iQEcBAEBAgAGBQJLe9BrAAoJEJBXh4mJ2FR+0K8IAKA43hk95Kll9mLfMWj5bUPp ZLlDzZPPy30Ign6wfbSO0wImLW0UVa9wAL0EwWb78F9T/3AJ2fQZFgWrOp/t+eV4 iKG8rsEy6t6YDYYZ7G6XnSibiCO+M+L+b6eSWMbcl/Ak8n+1PZUQisFevq/K0cCu 31ktjNxC6eqK1s0rKn/CgyXKO/rga60U12OHG9SLInM8J1dtHSGAp6kBO0B6C9+m uzEKOkUxXlYZpo+vlR9alByPWfiG9JqkgiYcOeXcgo0kb405cVT5jwBrOY9UnTb8 phxY6RXUViGP/quX2P+tGIYO47gDvBiGY/XRyTO1bmM+O0nPTnnKHpJg9NBvZ/g= =OFDn -----END PGP SIGNATURE-----