From owner-svn-src-head@freebsd.org  Fri Aug  7 15:26:04 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id CB78A3BCFF8;
 Fri,  7 Aug 2020 15:26:04 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BNThr1QlFz4XTp;
 Fri,  7 Aug 2020 15:26:02 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1])
 by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 077FQ0gB017441;
 Fri, 7 Aug 2020 08:26:00 -0700 (PDT)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: (from freebsd@localhost)
 by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 077FQ0uQ017440;
 Fri, 7 Aug 2020 08:26:00 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <202008071526.077FQ0uQ017440@gndrsh.dnsmgr.net>
Subject: Re: svn commit: r364010 - head/sbin/iscontrol
In-Reply-To: <202008071219.077CJLbH085411@repo.freebsd.org>
To: Emmanuel Vadot <manu@freebsd.org>
Date: Fri, 7 Aug 2020 08:26:00 -0700 (PDT)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 4BNThr1QlFz4XTp
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[];
 ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Aug 2020 15:26:04 -0000

> Author: manu
> Date: Fri Aug  7 12:19:21 2020
> New Revision: 364010
> URL: https://svnweb.freebsd.org/changeset/base/364010
> 
> Log:
>   pkgbase: We can't easily have a package with either a - or a _

Wow, hopefully this is short term.  I would think a package name can
be any valid file name, and to remove - and _ from that set is going
to cause lots of POLA.

>   
>   Rename iscsi_legacy to iscsilegacy, having - or _ in a package name cause
>   problems when we process them and generate the ucl.
> 
> Modified:
>   head/sbin/iscontrol/Makefile
> 
> Modified: head/sbin/iscontrol/Makefile
> ==============================================================================
> --- head/sbin/iscontrol/Makefile	Fri Aug  7 10:20:39 2020	(r364009)
> +++ head/sbin/iscontrol/Makefile	Fri Aug  7 12:19:21 2020	(r364010)
> @@ -1,6 +1,6 @@
>  # $FreeBSD$
>  
> -PACKAGE=iscsi_legacy
> +PACKAGE=iscsilegacy
>  SRCS= iscontrol.c pdu.c fsm.c config.c login.c auth_subr.c misc.c
>  PROG= iscontrol
>  LIBADD=	cam md
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org