From owner-freebsd-hackers Tue Oct 17 0:12:15 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from netplex.com.au (adsl-64-163-195-99.dsl.snfc21.pacbell.net [64.163.195.99]) by hub.freebsd.org (Postfix) with ESMTP id CF4AE37B4D7; Tue, 17 Oct 2000 00:12:08 -0700 (PDT) Received: from netplex.com.au (peter@localhost [127.0.0.1]) by netplex.com.au (8.11.0/8.9.3) with ESMTP id e9H7C3G58805; Tue, 17 Oct 2000 00:12:04 -0700 (PDT) (envelope-from peter@netplex.com.au) Message-Id: <200010170712.e9H7C3G58805@netplex.com.au> X-Mailer: exmh version 2.1.1 10/15/1999 To: Terry Lambert Cc: bright@wintelcom.net (Alfred Perlstein), gcorcoran@lucent.com (Gary T. Corcoran), freebsd-hackers@FreeBSD.ORG, freebsd-net@FreeBSD.ORG Subject: Re: Module parameters? (WildWire DSL card driver) In-Reply-To: <200010170428.VAA06237@usr01.primenet.com> Date: Tue, 17 Oct 2000 00:12:03 -0700 From: Peter Wemm Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Terry Lambert wrote: > > > > > > #define D_TRACKCLOSE 0x80000 /* track all closes */ > > > > > Under what circumstances is it permissable to _not_ set this bit? > > > > When you want the old behavior. > > > Under what circumstances is it permissable to want the old behaviour? > > > > Jeez Terry, I don't know, it's how it used to be so I assume it's for > > compatibility or for drivers that simply don't care. Am I missing > > something here? > > I guess I'm asking "What moron would want to intentionally disable > system resource tracking?". Who said anything about disabling system resource tracking? "track all closes" means to call the devsw d_close function for *each* close, not just for the "last close" as 99% of our drivers expect... If we suddenly caused d_close() to be called on every close() syscall, then existing drivers break because they are used to freeing everything and cleaning up when the close function is called. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message