Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Jul 2016 13:54:46 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r303442 - head/sys/conf
Message-ID:  <201607281354.u6SDskEb075421@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Thu Jul 28 13:54:46 2016
New Revision: 303442
URL: https://svnweb.freebsd.org/changeset/base/303442

Log:
  remove CONSTRUCTORS from kernel linker scripts
  
  The linker script CONSTRUCTORS keyword is only meaningful "when linking
  object file formats which do not support arbitrary sections, such as
  ECOFF and XCOFF"[1] and is ignored for other object file formats.
  
  LLVM's lld does not yet accept (and ignore) CONSTRUCTORS, so just remove
  CONSTRUCTORS from the linker scripts as it has no effect.
  
  [1] https://sourceware.org/binutils/docs/ld/Output-Section-Keywords.html
  
  Reviewed by:	kib
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D7343

Modified:
  head/sys/conf/ldscript.amd64
  head/sys/conf/ldscript.arm
  head/sys/conf/ldscript.arm64
  head/sys/conf/ldscript.i386
  head/sys/conf/ldscript.mips
  head/sys/conf/ldscript.mips.cfe
  head/sys/conf/ldscript.mips.mips64
  head/sys/conf/ldscript.mips.octeon1
  head/sys/conf/ldscript.powerpc
  head/sys/conf/ldscript.powerpc64
  head/sys/conf/ldscript.riscv
  head/sys/conf/ldscript.sparc64

Modified: head/sys/conf/ldscript.amd64
==============================================================================
--- head/sys/conf/ldscript.amd64	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.amd64	Thu Jul 28 13:54:46 2016	(r303442)
@@ -149,7 +149,6 @@ SECTIONS
   {
     *(.data .data.* .gnu.linkonce.d.*)
     KEEP (*(.gnu.linkonce.d.*personality*))
-    SORT(CONSTRUCTORS)
   }
   .data1          : { *(.data1) }
   _edata = .; PROVIDE (edata = .);

Modified: head/sys/conf/ldscript.arm
==============================================================================
--- head/sys/conf/ldscript.arm	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.arm	Thu Jul 28 13:54:46 2016	(r303442)
@@ -76,7 +76,6 @@ SECTIONS
   {
     *(.data)
     *(.gnu.linkonce.d*)
-    CONSTRUCTORS
   }
   .data1   : { *(.data1) }
   . = ALIGN(32 / 8);

Modified: head/sys/conf/ldscript.arm64
==============================================================================
--- head/sys/conf/ldscript.arm64	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.arm64	Thu Jul 28 13:54:46 2016	(r303442)
@@ -76,7 +76,6 @@ SECTIONS
   {
     *(.data)
     *(.gnu.linkonce.d*)
-    CONSTRUCTORS
   }
   .data1   : { *(.data1) }
   . = ALIGN(32 / 8);

Modified: head/sys/conf/ldscript.i386
==============================================================================
--- head/sys/conf/ldscript.i386	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.i386	Thu Jul 28 13:54:46 2016	(r303442)
@@ -137,7 +137,6 @@ SECTIONS
   {
     *(.data .data.* .gnu.linkonce.d.*)
     KEEP (*(.gnu.linkonce.d.*personality*))
-    SORT(CONSTRUCTORS)
   }
   .data1          : { *(.data1) }
   _edata = .; PROVIDE (edata = .);

Modified: head/sys/conf/ldscript.mips
==============================================================================
--- head/sys/conf/ldscript.mips	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.mips	Thu Jul 28 13:54:46 2016	(r303442)
@@ -184,7 +184,6 @@ SECTIONS
     *(.data)
     *(.data.*)
     *(.gnu.linkonce.d.*)
-    SORT(CONSTRUCTORS)
   }
   .data1   : { *(.data1) }
   .eh_frame : { KEEP (*(.eh_frame)) }

Modified: head/sys/conf/ldscript.mips.cfe
==============================================================================
--- head/sys/conf/ldscript.mips.cfe	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.mips.cfe	Thu Jul 28 13:54:46 2016	(r303442)
@@ -201,7 +201,6 @@ SECTIONS
     *(.data)
     *(.data.*)
     *(.gnu.linkonce.d.*)
-    SORT(CONSTRUCTORS)
   } :data
   .data1   : { *(.data1) }
   .eh_frame : { KEEP (*(.eh_frame)) }

Modified: head/sys/conf/ldscript.mips.mips64
==============================================================================
--- head/sys/conf/ldscript.mips.mips64	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.mips.mips64	Thu Jul 28 13:54:46 2016	(r303442)
@@ -185,7 +185,6 @@ SECTIONS
     *(.data)
     *(.data.*)
     *(.gnu.linkonce.d.*)
-    SORT(CONSTRUCTORS)
   }
   .data1   : { *(.data1) }
   .eh_frame : { KEEP (*(.eh_frame)) }

Modified: head/sys/conf/ldscript.mips.octeon1
==============================================================================
--- head/sys/conf/ldscript.mips.octeon1	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.mips.octeon1	Thu Jul 28 13:54:46 2016	(r303442)
@@ -28,7 +28,6 @@ SECTIONS {
                 _rwdata = .;
 	    	*(.data)
 		. = ALIGN(32);
-		CONSTRUCTORS;
 	}
 
 	_gp = (. + 0x8000);

Modified: head/sys/conf/ldscript.powerpc
==============================================================================
--- head/sys/conf/ldscript.powerpc	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.powerpc	Thu Jul 28 13:54:46 2016	(r303442)
@@ -63,7 +63,6 @@ SECTIONS
   {
     *(.data)
     *(.gnu.linkonce.d*)
-    CONSTRUCTORS
   }
   .data1   : { *(.data1) }
   .got1           : { *(.got1) }

Modified: head/sys/conf/ldscript.powerpc64
==============================================================================
--- head/sys/conf/ldscript.powerpc64	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.powerpc64	Thu Jul 28 13:54:46 2016	(r303442)
@@ -63,7 +63,6 @@ SECTIONS
   {
     *(.data)
     *(.gnu.linkonce.d*)
-    CONSTRUCTORS
   }
   .data1     : { *(.data1) }
   .toc1      : ALIGN(8) { *(.toc1) }

Modified: head/sys/conf/ldscript.riscv
==============================================================================
--- head/sys/conf/ldscript.riscv	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.riscv	Thu Jul 28 13:54:46 2016	(r303442)
@@ -63,7 +63,6 @@ SECTIONS
   {
     *(.data)
     *(.gnu.linkonce.d*)
-    CONSTRUCTORS
   }
   .data1   : { *(.data1) }
   . = ALIGN(32 / 8);

Modified: head/sys/conf/ldscript.sparc64
==============================================================================
--- head/sys/conf/ldscript.sparc64	Thu Jul 28 13:35:46 2016	(r303441)
+++ head/sys/conf/ldscript.sparc64	Thu Jul 28 13:54:46 2016	(r303442)
@@ -154,7 +154,6 @@ SECTIONS
     *(.data)
     *(.data.*)
     *(.gnu.linkonce.d.*)
-    SORT(CONSTRUCTORS)
   }
   .data1   : { *(.data1) }
   .eh_frame : { KEEP (*(.eh_frame)) }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201607281354.u6SDskEb075421>