From owner-freebsd-arch@FreeBSD.ORG  Thu Dec 25 18:01:29 2014
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9AFEA2AA;
 Thu, 25 Dec 2014 18:01:29 +0000 (UTC)
Received: from elvis.mu.org (elvis.mu.org [IPv6:2001:470:1f05:b76::196])
 by mx1.freebsd.org (Postfix) with ESMTP id 809922D9A;
 Thu, 25 Dec 2014 18:01:29 +0000 (UTC)
Received: from AlfredMacbookAir.local (c-76-21-10-192.hsd1.ca.comcast.net
 [76.21.10.192])
 by elvis.mu.org (Postfix) with ESMTPSA id EA1BC341F85F;
 Thu, 25 Dec 2014 10:01:28 -0800 (PST)
Message-ID: <549C50FB.6050908@mu.org>
Date: Thu, 25 Dec 2014 10:01:31 -0800
From: Alfred Perlstein <bright@mu.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: "Simon J. Gerraty" <sjg@juniper.net>
Subject: Re: Libxo bugs and fixes.
References: <201408141640.s7EGe422096656@idle.juniper.net>
 <53ED57F2.5020808@mu.org> <20140815053604.9E40B580A2@chaos.jnpr.net>
 <53EDB0EF.6090902@mu.org> <20140815173830.93832580A2@chaos.jnpr.net>
 <53EEA74B.9070107@mu.org> <20140816045254.5F47E580A2@chaos.jnpr.net>
 <549BA675.9070107@freebsd.org> <29784.1419492726@chaos>
 <26E73A9E-6EA4-4698-885D-BD91906D32D2@mu.org> <18276.1419528679@chaos>
In-Reply-To: <18276.1419528679@chaos>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcel Moolenaar <marcel@freebsd.org>, Phil Shafer <phil@juniper.net>,
 John-Mark Gurney <jmg@funkthat.com>, Alfred Perlstein <alfred@freebsd.org>,
 "arch@freebsd.org" <arch@freebsd.org>, Poul-Henning Kamp <phk@phk.freebsd.dk>,
 freebsd-arch <freebsd-arch@freebsd.org>,
 Konstantin Belousov <kostikbel@gmail.com>
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Dec 2014 18:01:29 -0000


On 12/25/14 9:31 AM, Simon J. Gerraty wrote:
> Alfred Perlstein <bright@mu.org> wrote:
>> Yes, the patch leaves it to the caller. The otherwise when you run "netstat --libxo json 1" you only see output every BUFSIZE bytes from netstat.
> I was refering to the call to xo_flush in xo_emit.
> The application best knows what are suitable points at which to flush
> its output.
> If you eliminate that call, it might be ok
>
I don't think my patch adds an xo_flush to xo_emit...  ?

Did I miss something?

Yes, there is an explicit flush at the end of xo_message_hcv() but that 
should be harmless or possibly removed since the output channel for 
warnings should be unbuffered.

-Alfred