From owner-cvs-all  Tue May 21 15: 3:40 2002
Delivered-To: cvs-all@freebsd.org
Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214])
	by hub.freebsd.org (Postfix) with ESMTP id D8A5537B408
	for <cvs-all@FreeBSD.org>; Tue, 21 May 2002 15:03:30 -0700 (PDT)
Received: (qmail 6094 invoked from network); 21 May 2002 22:03:29 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender <jhb@FreeBSD.org>)
          by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <arr@FreeBSD.org>; 21 May 2002 22:03:29 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4LM3RF96483;
	Tue, 21 May 2002 18:03:27 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20020521180307.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20020521213720.GL54960@elvis.mu.org>
Date: Tue, 21 May 2002 18:03:07 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Alfred Perlstein <bright@mu.org>
Subject: Re: cvs commit: src/sys/kern uipc_socket.c
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org,
	"Andrew R. Reiter" <arr@FreeBSD.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


On 21-May-2002 Alfred Perlstein wrote:
> * Andrew R. Reiter <arr@FreeBSD.org> [020521 14:18] wrote:
>> arr         2002/05/21 14:18:41 PDT
>> 
>>   Modified files:
>>     sys/kern             uipc_socket.c 
>>   Log:
>>   - OR the flag variable with M_ZERO so that the uma_zalloc() handles the
>>     zero'ing out of the allocated memory.  Also removed the logical bzero
>>     that followed.
> 
> This is just making something wrong prettier as well as obfuscating
> the problem and making the XXX comment not make sense.

The XXX already didn't make sense.  Why do you prefer explicit bzero()
to M_ZERO?

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message