From owner-freebsd-arch Sun Jul 7 4:20:18 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5340737B400; Sun, 7 Jul 2002 04:20:08 -0700 (PDT) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 83EF643E31; Sun, 7 Jul 2002 04:20:07 -0700 (PDT) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 86D8F534A; Sun, 7 Jul 2002 13:20:05 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: arch@freebsd.org Cc: obrien@freebsd.org Subject: -Werror removed from bsd.sys.mk From: Dag-Erling Smorgrav Date: 07 Jul 2002 13:20:04 +0200 Message-ID: Lines: 71 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Why was -Werror removed from bsd.sys.mk without any prior discussion, and with a log message that seems deliberately misleading? David, if you really hate -Werror, couldn't you just have added NO_WERROR to your make.conf instead of taking this valuable tool away from us? des@des /usr/src/share/mk% lcvs log -r1.9 bsd.sys.mk RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v Working file: bsd.sys.mk head: 1.9 branch: locks: strict access list: symbolic names: RELENG_4_6_0_RELEASE: 1.3.2.4 RELENG_4_6: 1.3.2.4.0.2 RELENG_4_6_BP: 1.3.2.4 RELENG_4_5_0_RELEASE: 1.3.2.3 RELENG_4_5: 1.3.2.3.0.4 RELENG_4_5_BP: 1.3.2.3 RELENG_4_4_0_RELEASE: 1.3.2.3 RELENG_4_4: 1.3.2.3.0.2 RELENG_4_4_BP: 1.3.2.3 RELENG_4: 1.3.0.2 keyword substitution: kv total revisions: 14; selected revisions: 1 description: ---------------------------- revision 1.9 date: 2002/05/19 18:24:00; author: obrien; state: Exp; lines: +1 -7 Tweak the WARNS levels a tad. ============================================================================= des@des /usr/src/share/mk% lcvs diff -r1.8 -r1.9 bsd.sys.mk Index: bsd.sys.mk =================================================================== RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- bsd.sys.mk 10 May 2002 01:58:16 -0000 1.8 +++ bsd.sys.mk 19 May 2002 18:24:00 -0000 1.9 @@ -1,4 +1,4 @@ -# $FreeBSD: src/share/mk/bsd.sys.mk,v 1.8 2002/05/10 01:58:16 obrien Exp $ +# $FreeBSD: src/share/mk/bsd.sys.mk,v 1.9 2002/05/19 18:24:00 obrien Exp $ # # This file contains common settings used for building FreeBSD # sources. @@ -11,9 +11,6 @@ .if !defined(NO_WARNS) . if defined(WARNS) . if ${WARNS} > 0 -. if !defined(NO_WERROR) -CFLAGS += -Werror -. endif . endif . if ${WARNS} > 1 CFLAGS += -Wall -Wno-format-y2k @@ -45,9 +42,6 @@ . if ${WFORMAT} > 0 #CFLAGS += -Wformat-nonliteral -Wformat-security -Wno-format-extra-args CFLAGS += -Wformat=2 -Wno-format-extra-args -. if !defined(NO_WERROR) -CFLAGS += -Werror -. endif . endif . endif .endif DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message