From owner-freebsd-current@FreeBSD.ORG Fri Apr 15 11:50:10 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AB4316A4CF; Fri, 15 Apr 2005 11:50:10 +0000 (GMT) Received: from aiolos.otenet.gr (aiolos.otenet.gr [195.170.0.23]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17C5B43D2F; Fri, 15 Apr 2005 11:50:09 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr [62.103.39.226])j3FBn3NO025229; Fri, 15 Apr 2005 14:49:03 +0300 Received: from orion.daedalusnetworks.priv (orion [127.0.0.1]) j3FBo6GD005903; Fri, 15 Apr 2005 14:50:06 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost)j3FBo5sk005902; Fri, 15 Apr 2005 14:50:05 +0300 (EEST) (envelope-from keramida@freebsd.org) Date: Fri, 15 Apr 2005 14:50:05 +0300 From: Giorgos Keramidas To: David Xu Message-ID: <20050415115005.GA5866@orion.daedalusnetworks.priv> References: <425CC7F8.3030803@samsco.org> <425CD009.6040208@freebsd.org> <20050413132603.GA39006@orion.daedalusnetworks.priv> <425D2163.4090603@freebsd.org> <20050413140838.GA77217@renaissance.homeip.net> <20050413141957.GA40546@orion.daedalusnetworks.priv> <20050415055604.N93987@lexi.siliconlandmark.com> <20050415104814.GA5278@orion.daedalusnetworks.priv> <425FA2AB.4070905@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <425FA2AB.4070905@freebsd.org> cc: freebsd-current@freebsd.org cc: Anthony Ginepro cc: Jiawei Ye Subject: Re: How does one know how many thread a process owns? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2005 11:50:10 -0000 On 2005-04-15 19:16, David Xu wrote: >Giorgos Keramidas wrote: >>On 2005-04-15 06:02, Andre Guibert de Bruet wrote: >>>Please commit the following patch which unbreaks the display problems >>>which appear on 80-column terminals with the THR column (The D would >>>wrap and cause weird behavior): >>> >>>http://bling.properkernel.com/freebsd/top.machine.c.patch >> >>David, do you think it's ok to change s/COMMAND/CMD/ or is that too >>silly to do to fit THR in there? I can probably reduce the columns of >>THR to 4 too, since I noticed that after 1500 threads the value of THR >>doesn't increase anymore here; so, being able to display up to 9999 >>threads is ok I guess. > > I think we should change THR columns to 4, > 9999 threads is okay for me. I just checked what top does on SunOS, when a program has more than 999 threads and it seems to clip the number of threads to 999, as if something min(999, numthreads) is what is printed :-) I'll change the width of THR to 4 columns if that's enough to fix the wrapping issue of COMMAND, or even to 3 if that is not enough. Clipping the value of numthreads to something less than or equal to 999 is also a relatively good idea that shouldn't be too hard to implement.