Date: Fri, 15 Apr 2005 14:50:05 +0300 From: Giorgos Keramidas <keramida@freebsd.org> To: David Xu <davidxu@freebsd.org> Cc: Jiawei Ye <leafy7382@gmail.com> Subject: Re: How does one know how many thread a process owns? Message-ID: <20050415115005.GA5866@orion.daedalusnetworks.priv> In-Reply-To: <425FA2AB.4070905@freebsd.org> References: <425CC7F8.3030803@samsco.org> <425CD009.6040208@freebsd.org> <c21e92e205041302152c9cbaaf@mail.gmail.com> <20050413132603.GA39006@orion.daedalusnetworks.priv> <425D2163.4090603@freebsd.org> <20050413140838.GA77217@renaissance.homeip.net> <20050413141957.GA40546@orion.daedalusnetworks.priv> <20050415055604.N93987@lexi.siliconlandmark.com> <20050415104814.GA5278@orion.daedalusnetworks.priv> <425FA2AB.4070905@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2005-04-15 19:16, David Xu <davidxu@freebsd.org> wrote: >Giorgos Keramidas wrote: >>On 2005-04-15 06:02, Andre Guibert de Bruet <andy@siliconlandmark.com> wrote: >>>Please commit the following patch which unbreaks the display problems >>>which appear on 80-column terminals with the THR column (The D would >>>wrap and cause weird behavior): >>> >>>http://bling.properkernel.com/freebsd/top.machine.c.patch >> >>David, do you think it's ok to change s/COMMAND/CMD/ or is that too >>silly to do to fit THR in there? I can probably reduce the columns of >>THR to 4 too, since I noticed that after 1500 threads the value of THR >>doesn't increase anymore here; so, being able to display up to 9999 >>threads is ok I guess. > > I think we should change THR columns to 4, > 9999 threads is okay for me. I just checked what top does on SunOS, when a program has more than 999 threads and it seems to clip the number of threads to 999, as if something min(999, numthreads) is what is printed :-) I'll change the width of THR to 4 columns if that's enough to fix the wrapping issue of COMMAND, or even to 3 if that is not enough. Clipping the value of numthreads to something less than or equal to 999 is also a relatively good idea that shouldn't be too hard to implement.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050415115005.GA5866>