From owner-svn-src-all@FreeBSD.ORG Thu Oct 1 17:33:06 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE5D6106566B for ; Thu, 1 Oct 2009 17:33:06 +0000 (UTC) (envelope-from cokane@FreeBSD.org) Received: from mail-out2.fuse.net (mail-out2.fuse.net [216.68.8.171]) by mx1.freebsd.org (Postfix) with ESMTP id 9CD2A8FC1D for ; Thu, 1 Oct 2009 17:33:06 +0000 (UTC) X-CNFS-Analysis: v=1.1 cv=Xmf0kUNlEPs5s0ASnO9nu/pAoGSimOtKYqLqs2wbnTI= c=1 sm=0 a=YYkPiygOjqcA:10 a=6I5d2MoRAAAA:8 a=Np3HAU8pmarTHa0tFysA:9 a=eqrwBVwXiQLXoHdL3wYA:7 a=TySv0dik-W_9h2_QBeQ99Uc-eaEA:4 a=SV7veod9ZcQA:10 a=ZgY7fN_rChvVf6XDDMEA:9 a=sU853Es58JrRFljXahj9cY1f0xMA:4 a=LkYvsgB9u1MH7Ao0BLhsLg==:117 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine Authentication-Results: ecout2 smtp.mail=cokane@FreeBSD.org; spf=softfail Received-SPF: softfail (ecout2: transitional domain FreeBSD.org does not designate 74.215.227.9 as permitted sender) Received: from [74.215.227.9] ([74.215.227.9:50311] helo=mail.colemankane.org) by ecout2 (envelope-from ) (ecelerity 2.2.2.43 r()) with ESMTP id C2/B6-05863-0D7E4CA4; Thu, 01 Oct 2009 13:33:05 -0400 Received: from [172.20.0.76] (rrcs-96-11-231-210.central.biz.rr.com [96.11.231.210]) by mail.colemankane.org (Postfix) with ESMTPSA id 4B40E1143E; Thu, 1 Oct 2009 14:38:02 -0400 (EDT) From: Coleman Kane To: Bruce Evans In-Reply-To: <20091002002534.D21507@delplex.bde.org> References: <200910010243.n912hpSM034846@svn.freebsd.org> <86eipno12p.fsf@ds4.des.no> <20091002002534.D21507@delplex.bde.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Eb9wi9n/DFmYjo6p2yUi" Organization: FreeBSD Project Date: Thu, 01 Oct 2009 13:32:25 -0400 Message-Id: <1254418346.4255.31.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port Cc: svn-src-head@freebsd.org, Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r197654 - head/sys/dev/if_ndis X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2009 17:33:06 -0000 --=-Eb9wi9n/DFmYjo6p2yUi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2009-10-02 at 00:36 +1000, Bruce Evans wrote: > On Thu, 1 Oct 2009, [utf-8] Dag-Erling Sm=C3=B8rgrav wrote: >=20 > > Coleman Kane writes: > >> - if (sc->ndis_80211 && vap) > >> + if ((sc->ndis_80211 !=3D NULL) && (vap !=3D NULL)) > > > > sc->ndis_80211 is an int. NULL is a pointer. >=20 > Also, the number of style bugs was doubled on (almost?) every changed lin= e > by adding 2 sets of unnecessary parentheses. >=20 > Bruce Re-read style(9) more closely. Yes... the extra parentheses are superfluous, and should therefore be removed. However, the current rev, which looks like this: if ((sc->ndis_80211 !=3D 0) && (vap !=3D NULL)) doesn't help the author shoot themselves in the foot as violating the "explicitly compare values to zero" rule did in the earlier revision. I'll heed the request of the second-to-last paragraph of style(9) on this particular change, not churning the SVN repo further, and make a mental note for later. --=20 Coleman Kane --=-Eb9wi9n/DFmYjo6p2yUi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEABECAAYFAkrE56kACgkQcMSxQcXat5cXTACfV1aTRY0HckK3TnAhNl4FHqtJ 8LAAnRhOkgNdnlOCO5Nl22wiuqCNWuC5 =wUWs -----END PGP SIGNATURE----- --=-Eb9wi9n/DFmYjo6p2yUi--