From owner-svn-src-all@freebsd.org Sun Sep 1 18:07:08 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5962AE0A20; Sun, 1 Sep 2019 18:07:08 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M1Q32Flmz4bwf; Sun, 1 Sep 2019 18:07:06 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x429.google.com with SMTP id 26so5185062pfp.9; Sun, 01 Sep 2019 11:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2Sg8Q4RHPqVnWr7IChs8WC/pCNLzKBqHw1zhOBBJgbE=; b=UCMa5wUUv54b8XA3/0JjtaZ5f+NmriJdl/sB1YwKzHAVbZrG5Tm80E2gHPTVGgC79Q VMEH7g1k247P4AFNbtw1c9DnyY86xV9A8GImsGgSPI2tsCjxECELFCttQDotnc61kSU0 HUPcWhyhK1jsrd/vg4QjHdpM53LU5nspRpQaEQgZZkCbxDzTL+BSd7PuVgs1xEb8IcGQ M6WQFt9eqTfzM6Msh0koJ4hcJSKRF21dWMv/XtyOol/hMHXY5hg+SrZ3NB1rziz1C0iF jYe+AK3PcFcQBlhzbDueLbZHpIhqQf+8DA5s4Yb9vyCGwB4kq6z2ptVCBAdZKcPh4R7Z +DDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2Sg8Q4RHPqVnWr7IChs8WC/pCNLzKBqHw1zhOBBJgbE=; b=eXNKjaPy5VNqC2IGDKq182Q00zCxvaThzIOiFpnQV0rwXsPpVIZN9ZzUoyI+Q6pXAz eZuCwKimkNjYJ/owB5bFqXx4zcIk4hsnC6mikhrmLaKxM+aGgG4hQuHwk8MCKHoIE4h4 MFEAjFRUPS6CSgpD2LsKp5yypZZjMlhjJjUurV87ui9KdMhSATzdJBuzN8x10kVYjIJU RGDILpGPhRL3HWXWtYnliBRsUriTZXxP6uFo4dB94FtPdlxeWO3btifFcEEKgBoXw7vx JUvxOaHRVFDNfPqWNNyNut1hyQg8FMLfcRAuBdZTX8nn+VlmWNtFHvbFad5HBL8DIMAN QwrA== X-Gm-Message-State: APjAAAXVHvj6zhJ8YeetODBd3Lnsu/eexuXOSmuMXkw6rh6j6JCqTZpw jGIbqtjQxkxVK/3fnNVjbxdk478q+Xw= X-Google-Smtp-Source: APXvYqz5RZHq4+sahw95ENEB+iwuUmyJJfYnZGp0OmvH07KxXFGhxFRbXT8M4pVyrWz6wRRAe7ymiQ== X-Received: by 2002:a63:5a0a:: with SMTP id o10mr22256407pgb.282.1567361224896; Sun, 01 Sep 2019 11:07:04 -0700 (PDT) Received: from ?IPv6:2607:fb90:b2d7:b4b0:a1f5:e714:1d1e:dbe5? ([2607:fb90:b2d7:b4b0:a1f5:e714:1d1e:dbe5]) by smtp.gmail.com with ESMTPSA id v18sm2152733pfn.24.2019.09.01.11.07.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Sep 2019 11:07:03 -0700 (PDT) Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r351643 - in head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common: dtraceUtil speculation From: Enji Cooper X-Mailer: iPhone Mail (16G77) In-Reply-To: Date: Sun, 1 Sep 2019 11:07:01 -0700 Cc: "Conrad E. Meyer" , Li-Wen Hsu , src-committers , svn-src-all , svn-src-head Message-Id: References: <201908311441.x7VEfwZ3045957@repo.freebsd.org> To: Warner Losh X-Rspamd-Queue-Id: 46M1Q32Flmz4bwf X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=UCMa5wUU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::429 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-3.49 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.99)[-0.986,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-8.20), ipnet: 2607:f8b0::/32(-2.83), asn: 15169(-2.31), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[9.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 18:07:08 -0000 > On Aug 31, 2019, at 16:29, Warner Losh wrote: >=20 >=20 >=20 >> On Sat, Aug 31, 2019 at 5:29 PM Conrad Meyer wrote: >> Thanks Li-Wen! Might it be less fragile to have the test fixture >> create a file, if the test(s) will expect one to be present to read? >=20 > Or just use the realpath $0, which you know has to exist :) I don=E2=80=99t know if this would work, with other some of the dtrace tests= are called. Plus, that relies on a FreeBSD utility which doesn=E2=80=99t ne= cessarily exist on Linux and I don=E2=80=99t think exists on IllumOS. It makes more sense to create a file with mktemp and test for it in the loop= to make the tests portable over to IllumOS, since that=E2=80=99s where they= originally came from and can be contributed back to. Thanks, -Enji=