From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 22 16:00:05 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7D9C106566B for ; Tue, 22 Mar 2011 16:00:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7DCCF8FC1D for ; Tue, 22 Mar 2011 16:00:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p2MG05uN009038 for ; Tue, 22 Mar 2011 16:00:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p2MG05eu009037; Tue, 22 Mar 2011 16:00:05 GMT (envelope-from gnats) Resent-Date: Tue, 22 Mar 2011 16:00:05 GMT Resent-Message-Id: <201103221600.p2MG05eu009037@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jim Pirzyk Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1DF1106564A for ; Tue, 22 Mar 2011 15:58:35 +0000 (UTC) (envelope-from pirzyk@freebsd.org) Received: from zoot.intenex.net (zoot.intenex.net [216.93.182.12]) by mx1.freebsd.org (Postfix) with ESMTP id 9DAF38FC0C for ; Tue, 22 Mar 2011 15:58:35 +0000 (UTC) Received: from [192.168.218.46] (c1fw238.constantcontact.com [205.207.104.238]) (authenticated bits=0) by zoot.intenex.net (8.13.8/8.13.8) with ESMTP id p2MFwQbt019747 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Tue, 22 Mar 2011 10:58:27 -0500 Message-Id: <93611D77-F2D7-4E2D-8839-35A1C72C2F26@freebsd.org> Date: Tue, 22 Mar 2011 11:58:19 -0400 From: Jim Pirzyk To: FreeBSD-gnats-submit@FreeBSD.org Cc: Subject: bin/155786: '/bin/test -d' fails to report syntax error X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2011 16:00:06 -0000 Note: There was a bad value `no=20' for the field `>Confidential:'. It was set to the default value of `yes'. >Number: 155786 >Category: bin >Synopsis: '/bin/test -d' fails to report syntax error >Confidential: yes >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 22 16:00:05 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Jim Pirzyk >Release: FreeBSD 8.2-RELEASE amd64 >Organization: =09 >Environment: System: FreeBSD freebsd.home.pirzyk.org 8.2-RELEASE FreeBSD 8.2-RELEASE = #0: Thu Feb 17 02:41:51 UTC 2011 = root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Running the command '/bin/test -d' does not report a syntax = error, like it does on Solaris systems. >How-To-Repeat: FreeBSD $ /bin/test -d; echo $? 0 Solaris $ /bin/test -d ; echo $? ksh: test: argument expected 2 >Fix: - --- ./bin/test/test.c.orig 2011-02-27 14:02:10.000000000 -0500 +++ ./bin/test/test.c 2011-03-22 11:35:03.000000000 -0400 @@ -424,12 +424,12 @@ } while (op->op_text) { if (strcmp(s, op->op_text) =3D=3D 0) { + t_wp_op =3D op; if (((op->op_type =3D=3D UNOP || op->op_type =3D=3D= BUNOP) && isunopoperand()) || (op->op_num =3D=3D LPAREN && = islparenoperand()) || (op->op_num =3D=3D RPAREN && = isrparenoperand())) - - break; - - t_wp_op =3D op; + syntax(t_wp_op->op_text, "argument = expected"); return op->op_num; } op++; - --- @(#) $Id: dot.signature,v 1.15 2007/12/27 15:06:13 pirzyk Exp $ __o jim@pirzyk.org = -------------------------------------------------- _'\<,_ (*)/ (*) I'd rather be out biking. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (Darwin) iQEVAwUBTYjHHBMKjZgDurkjAQJJ5AgAzYuq5LGcQBbXuyDrqHlrekAqfa8aO9Nm 5r3NpQwewYdkHUCY+zQFjht+k3/ykahQVX9dUrjDnh1Xr129lApFz8Rq3p6YGdCl wlPJIwUREqJQ4rdqVRLOdBcwapPD2ITq8CHWuQ4vhb9NqjNOcMHptLA4ym21e1bk ItCCX/2jLzQ3qT5Cm5O6WRlQUOK+vbkLfoogOny5iG9oeDxRCTo4dd963/NnVFUX VYwLs+265x6wQ7feXYjl9pZ/C9/INkhHqkRbd2ps5njJev9KmEFLYwEGJNhGMsFL Ld6DvJIJaMuO4LP5PgUEL0qVHg9B9aEqrjsbT/uamfx7qhpOLSB4Rg=3D=3D =3DGGqm -----END PGP SIGNATURE----- >Release-Note: >Audit-Trail: >Unformatted: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1