From owner-cvs-src@FreeBSD.ORG  Wed Feb  1 18:51:13 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E07A116A420;
	Wed,  1 Feb 2006 18:51:13 +0000 (GMT)
	(envelope-from bakul@bitblocks.com)
Received: from gate.bitblocks.com (bitblocks.com [209.204.185.216])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8D0A443D53;
	Wed,  1 Feb 2006 18:51:13 +0000 (GMT)
	(envelope-from bakul@bitblocks.com)
Received: from bitblocks.com (localhost [127.0.0.1])
	by gate.bitblocks.com (8.13.4/8.13.1) with ESMTP id k11Ip8VO071628;
	Wed, 1 Feb 2006 10:51:08 -0800 (PST)
	(envelope-from bakul@bitblocks.com)
Message-Id: <200602011851.k11Ip8VO071628@gate.bitblocks.com>
To: Kris Kennaway <kris@obsecurity.org>
In-reply-to: Your message of "Wed, 01 Feb 2006 13:30:36 EST."
	<20060201183036.GA30206@xor.obsecurity.org> 
Date: Wed, 01 Feb 2006 10:51:08 -0800
From: Bakul Shah <bakul@BitBlocks.com>
Cc: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org,
	stefanf@freebsd.org, ru@freebsd.org,
	sgk@troutmask.apl.washington.edu, stefan@fafoe.narf.at,
	Warner Losh <imp@bsdimp.com>
Subject: Re: cvs commit: src/sys/sys cdefs.h src/include nl_types.h stdio.h 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Feb 2006 18:51:14 -0000

> On Wed, Feb 01, 2006 at 10:25:28AM -0800, Bakul Shah wrote:
> > > I'm actually surprised that make includes doesn't install the sys
> > > directory as well, which would pick up the new sys/cdefs.h.  Does
> > > 'make -f Makefile.inc _includes' also exhibit the same problem?
> >=20
> > The bigger question is *why* does buildworld depend on
> > /usr/include.
> 
> You have to compile native bootstrap tools (i.e. against /usr/include)
> before you can build the rest of the world with "internal" headers.
> If you don't do this bootstrap step, your buildworld won't work in all
> upgrade cases.

But look at this error message Steve Kargl posted:

===> games/fortune/strfile (obj,depend,all,install)
cc -O2 -fno-strict-aliasing -pipe  -I/usr/obj/usr/src/tmp/legacy/usr/include -c
/usr/src/games/fortune/strfile/strfile.c
In file included from /usr/src/games/fortune/strfile/strfile.c:53:
/usr/include/stdio.h:331: error: syntax error before "__format_arg"

Is /usr/games/fortune is a build tool?  Even if /usr/includes
is not consistent due to make includes, surely fortune
shouldn't care since it includes only the "internal" headers?
Internal meaning the ones in the target system.

BTW, I have seen similar things in the past few weeks while
doing buildworld and the only way to fix this was to do make
includes.

Anyway, if it is only build tools that rely on host includes,
why do you need make includes at all?  If you do, that says
that the build tools are relying on new stuff that they are
supposed to help build and install.

More generally don't the build tools need to have an even
more stable environment?