From owner-freebsd-current@FreeBSD.ORG Thu Mar 29 19:43:52 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C5CB16A400 for ; Thu, 29 Mar 2007 19:43:52 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id DEC1713C4AE for ; Thu, 29 Mar 2007 19:43:51 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 5DD82208D; Thu, 29 Mar 2007 21:43:46 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on tim.des.no Received: from dwp.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 4CC5F208A; Thu, 29 Mar 2007 21:43:45 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 1001) id 9D6D9A1075; Thu, 29 Mar 2007 21:43:45 +0200 (CEST) From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: Peter Jeremy References: <460AE39B.4070706@root.org> <86odmcqylx.fsf@dwp.des.no> <200703291905.00192.pieter@degoeje.nl> <86k5wzq4vx.fsf@dwp.des.no> <20070329191613.GB827@turion.vk2pj.dyndns.org> Date: Thu, 29 Mar 2007 21:43:45 +0200 In-Reply-To: <20070329191613.GB827@turion.vk2pj.dyndns.org> (Peter Jeremy's message of "Fri, 30 Mar 2007 05:16:13 +1000") Message-ID: <86y7lfomxa.fsf@dwp.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: current@freebsd.org, Nate Lawson Subject: Re: libfetch ftp patch for less latency X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2007 19:43:52 -0000 Peter Jeremy writes: > At first glance, the current behaviour does seem unnecessary and > Nate's patch seems an "obvious" improvement. Having a comment near > _ftp_cwd() explaining the current behaviour and why it isn't possible > to pass a pathname to CWD would have saved Nate some effort and > removed the need for this thread. > > Sometimes, it is as important to document why an alternative algorithm > was not chosen as it is to document what the code is doing. Isn't that why we have CVS logs? ---------------------------- revision 1.92 date: 2005/08/12 12:48:50; author: des; state: Exp; lines: +152 -29 Change directory one level at a time, and use CDUP to back out. This is a work in progress; it partially fixed bin/83278 and is a prerequisite to fixing bin/83277. PR: bin/83277, bin/83278 ---------------------------- DES --=20 Dag-Erling Sm=F8rgrav - des@des.no