From owner-freebsd-ports-bugs@freebsd.org Tue May 31 16:51:54 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DDDD4B55676 for ; Tue, 31 May 2016 16:51:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AE11217DE for ; Tue, 31 May 2016 16:51:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u4VGps8n012550 for ; Tue, 31 May 2016 16:51:54 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209894] security/clamav-unofficial-sigs Update to 5.3.2 (patch included) Date: Tue, 31 May 2016 16:51:54 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: sf@maxempire.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2016 16:51:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209894 --- Comment #1 from Marko Njezic --- The main reason why I did not submit an update to one of the latest version= s is because there were quite a lot of the disruptive changes and released versi= ons were sometimes followed with immediate fixes and I would prefer for all the changes to stabilize first. I took a brief look at your patch and there are some changes that I can't approve: - There's no need to rename the script. - Manual page should be installed by the port. I know that the script now generates manual page and it should generate one during port build stage. I= 'm also aware that this is not really straightforward, since the script would require some changes in order to be able to generate manual page inside work directory. - logging_enabled=3D"no" should be kept in master.conf and log_file_path sh= ould be set to "/var/log", since that was the location chosen from day one of the port. - You have hardcoded /usr/local/etc/ prefix in your patch - You have removed pkg_mgr and pkg_rm variables from the clamav-unofficial-sigs.sh script - You have changed port dependency from gnupg to gnupg1 Besides this, port documentation (pkg-message) needs updating. I would also like to make a change to the default configuration to disable = yara rules by default (like they were in 5.0.X series). --=20 You are receiving this mail because: You are the assignee for the bug.=