From owner-svn-src-all@freebsd.org Mon Nov 28 01:18:35 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2CAEC58666; Mon, 28 Nov 2016 01:18:35 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8B1B337B7; Mon, 28 Nov 2016 01:18:35 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-io0-x236.google.com with SMTP id j65so206089669iof.0; Sun, 27 Nov 2016 17:18:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wbo7MZvWYfYvnTuw53nKridc4z8bDPTwnYEIq778Sb0=; b=0rW2zxTcSii7LykzKU0vHgWDF89EkdNPZGCGwGflqhSIsLFFAMchI4/kS8DmLktT6x VzNJtSvYsugtrSF1ydebqhLO3/eqH9MWRSMLpcxzoO1ACJnLyTuY/G31Ci0ITPrHP9Hs xdVmrGIpLaljP3mUb9UrlRxmQGTsga/y4i/ruNSqorY46exQuZu8yPvlV+t2GJJ4iGe4 GQn4JGXcAw9DHjF2SMaEUdvV4XxVpCgxYLtF6OXti6XTvIEF6BfbGUPoLfZ1u7GQPWmx dYqL5udiKJQsV70VljGEVPFOhl4fC2t4khEdVpXoYvVyjG879p3uF6y50OCYadJU4+kE q98w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wbo7MZvWYfYvnTuw53nKridc4z8bDPTwnYEIq778Sb0=; b=Pynwzdt0rMqF37estWucqSvT59UIYbgL6NA+s50xyWvWOZJp+923UUIe4IVJC3Ns8y 7Uy4Kg1E+7OiENB3MdatCxKOJFdoyes4CXhBD3ZdZr3EsB/ta0kbE0OxFDoWjx8hrruJ aIP4DD/0wrgzzAhuD6crhSrrHqdETRtUzWNNfielmDUtqKe6HdQEuF38nvrb0vO7bas5 3KXjYoUEK+HTEmvfKlvdTvEoNWHQJgNlENjpKHrHEtXgC7I+QKBUJD2ZDhi8G9IMS9Hs ru/MD8vcQHal+ypVHlSnT2s1sTEFzPyhrTsgf6IHuzbfYM0mjKly/gV6tCaoBV2JDCfl 6Uhw== X-Gm-Message-State: AKaTC018xVfwA6d/TldVvHoDE0CcwMNA6TJ5trxl0JqMo9qVev9SeWptVJJJtBe0HS+ChhREL25TaYAoRTXojA== X-Received: by 10.107.18.230 with SMTP id 99mr14876367ios.41.1480295914924; Sun, 27 Nov 2016 17:18:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.152.204 with HTTP; Sun, 27 Nov 2016 17:18:34 -0800 (PST) In-Reply-To: References: <201611261550.uAQFo0HC074016@repo.freebsd.org> From: Ryan Stone Date: Sun, 27 Nov 2016 20:18:34 -0500 Message-ID: Subject: Re: svn commit: r309194 - head/usr.sbin/syslogd To: Baptiste Daroussin Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2016 01:18:35 -0000 > > There is something very wrong in the code here. nextp is never > initialized, so obviously we can't access *nextp. I'm surprised that this > code can even compile with -Werror. I'd fix it but it'd not clear to me > what nextp is intended to do. > Apologies for the noise; I didn't see r309216, which properly initialized nextp.