From owner-svn-src-head@FreeBSD.ORG Tue Mar 17 08:03:02 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AFF4BE91; Tue, 17 Mar 2015 08:03:02 +0000 (UTC) Received: from mail-lb0-x234.google.com (mail-lb0-x234.google.com [IPv6:2a00:1450:4010:c04::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 27DBD1A6; Tue, 17 Mar 2015 08:03:02 +0000 (UTC) Received: by lbcds1 with SMTP id ds1so1305036lbc.3; Tue, 17 Mar 2015 01:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=XpNpJ0iVMhM+hpZnkCdTebaAMLWwsvF2cTXH7gQNzzE=; b=nLaEHi3BN5bDlbuIukl/cbdu3qBeARoXB3LMKTE17m+Yau9gusa3vgRMeZJYxTcYRC YEm4VtjAVA0qQkyKTpHtJkWmv0NkeO0JpWLlxDMFnrnG6V+7/G7R3SKyM++XFNibaphB TVg2sAFmeuCtYGGypf6x9UbuSa86CQGcav7DZuAQsn+eG5fVk7CdHamnuwqP3B/QLUuA PEhEw6d1FVx2QcVkAUAQeLgsBEmTfZnDVMFGWgaJFLCeHcwtau/B0EnQLYjCMbWDd/uA w9IzllDdze2/eudjJ2Hqkzpbdw6CBOMpU268jbMYio85/nrrrjPvp58gsiRXEmJJ06Wa inpQ== X-Received: by 10.112.212.106 with SMTP id nj10mr39900799lbc.36.1426579380075; Tue, 17 Mar 2015 01:03:00 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([134.249.139.101]) by mx.google.com with ESMTPSA id ei4sm2649282lad.31.2015.03.17.01.02.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Mar 2015 01:02:58 -0700 (PDT) Sender: Alexander Motin Message-ID: <5507DFAF.9000808@FreeBSD.org> Date: Tue, 17 Mar 2015 10:02:55 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Justin T. Gibbs" Subject: Re: svn commit: r280133 - head/usr.sbin/bhyve References: <201503160916.t2G9G01e095354@svn.freebsd.org> <6A7A51CE-9EAA-4F62-BECB-3CFDD708E06E@scsiguy.com> In-Reply-To: <6A7A51CE-9EAA-4F62-BECB-3CFDD708E06E@scsiguy.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2015 08:03:02 -0000 On 17.03.2015 02:38, Justin T. Gibbs wrote: > On Mar 16, 2015, at 3:16 AM, Alexander Motin wrote: >> >> Author: mav >> Date: Mon Mar 16 09:15:59 2015 >> New Revision: 280133 >> URL: https://svnweb.freebsd.org/changeset/base/280133 >> >> Log: >> Increase S/G list size of 32 to 33 entries. >> >> 32 entries are not enough for the worst case of misaligned 128KB request, >> that made FreeBSD to chunk large quests in odd pieces. >> >> MFC after: 2 weeks >> >> Modified: >> head/usr.sbin/bhyve/block_if.h >> head/usr.sbin/bhyve/pci_virtio_block.c >> >> Modified: head/usr.sbin/bhyve/block_if.h >> ============================================================================== >> --- head/usr.sbin/bhyve/block_if.h Mon Mar 16 01:15:08 2015 (r280132) >> +++ head/usr.sbin/bhyve/block_if.h Mon Mar 16 09:15:59 2015 (r280133) >> @@ -39,7 +39,7 @@ >> #include >> #include >> >> -#define BLOCKIF_IOV_MAX 32 /* not practical to be IOV_MAX */ >> +#define BLOCKIF_IOV_MAX 33 /* not practical to be IOV_MAX */ > > Shouldn’t these be derived from MAXPHYS? I am not sure. This is user-level, what it know about MAXPHYS? And what MAXPHYS means for file I/O? It may be more tuned for guest's potential MAXPHYS rather then host's one. -- Alexander Motin