From owner-svn-src-head@freebsd.org Tue Apr 19 15:49:59 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71EC1B1499D; Tue, 19 Apr 2016 15:49:59 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) by mx1.freebsd.org (Postfix) with ESMTP id 33B3417AE; Tue, 19 Apr 2016 15:49:58 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (unknown [10.1.1.2]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 81B51D63C; Tue, 19 Apr 2016 15:49:58 +0000 (UTC) Subject: Re: svn commit: r298230 - in head: lib/libstand sys/boot/common sys/boot/efi/libefi sys/boot/efi/loader sys/boot/i386/libfirewire sys/boot/i386/libi386 sys/boot/i386/loader sys/boot/mips/beri/loader sy... To: "Bjoern A. Zeeb" References: <201604182309.u3IN9MC6047480@repo.freebsd.org> <3DB7C327-E42A-44AB-A1CB-FA34698B2CF3@lists.zabbadoz.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Allan Jude Message-ID: <571653A6.5000700@freebsd.org> Date: Tue, 19 Apr 2016 11:49:58 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <3DB7C327-E42A-44AB-A1CB-FA34698B2CF3@lists.zabbadoz.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 15:49:59 -0000 On 2016-04-19 05:08, Bjoern A. Zeeb wrote: > >> On 18 Apr 2016, at 23:09 , Allan Jude wrote: >> >> Author: allanjude >> Date: Mon Apr 18 23:09:22 2016 >> New Revision: 298230 >> URL: https://svnweb.freebsd.org/changeset/base/298230 >> > > Can you have a look at this please? > > ===> sys/boot/pc98/libpc98 (all) > /scratch/tmp/bz/head.svn/sys/boot/pc98/libpc98/biosdisk.c:132:5: warning: incompatible pointer types initializing 'int (*)(void *, int, daddr_t, size_t, size_t, char *, size_t *)' (aka 'int (*)(void *, int, long long, unsigned int, unsigned int > , char *, unsigned int *)') with an expression of type 'int (void *, int, daddr_t, size_t, char *, size_t *)' (aka 'int (void *, int, long long, unsigned int, char *, unsigned int *)') [-Wincompatible-pointer-types] > bd_strategy, > ^~~~~~~~~~~ > /scratch/tmp/bz/head.svn/sys/boot/pc98/libpc98/biosdisk.c:736:1: error: conflicting types for 'bd_strategy' > bd_strategy(void *devdata, int rw, daddr_t dblk, size_t offset, size_t size, > ^ > /scratch/tmp/bz/head.svn/sys/boot/pc98/libpc98/biosdisk.c:120:12: note: previous declaration is here > static int bd_strategy(void *devdata, int flag, daddr_t dblk, > ^ > /scratch/tmp/bz/head.svn/sys/boot/pc98/libpc98/biosdisk.c:740:33: error: use of undeclared identifier 'f' > struct i386_devdesc *dev = f->f_devdata; > ^ > /scratch/tmp/bz/head.svn/sys/boot/pc98/libpc98/biosdisk.c:743:21: warning: incompatible pointer types assigning to 'int (*)(void *, int, daddr_t, size_t, size_t, char *, size_t *)' (aka 'int (*)(void *, int, long long, unsigned int, unsigned in > t, char *, unsigned int *)') from 'int (void *, int, daddr_t, size_t, char *, size_t *)' (aka 'int (void *, int, long long, unsigned int, char *, unsigned int *)') [-Wincompatible-pointer-types] > bcd.dv_strategy = bd_realstrategy; > ^ ~~~~~~~~~~~~~~~ > /scratch/tmp/bz/head.svn/sys/boot/pc98/libpc98/biosdisk.c:747:13: error: too many arguments to function call, expected 7, have 8 > size, buf, rsize)); > ^~~~~ > /scratch/tmp/bz/head.svn/sys/boot/pc98/libpc98/../../common/bootstrap.h:79:1: note: 'bcache_strategy' declared here > int bcache_strategy(void *devdata, int rw, daddr_t blk, size_t offset, > ^ > /scratch/tmp/bz/head.svn/sys/boot/pc98/libpc98/biosdisk.c:751:1: error: conflicting types for 'bd_realstrategy' > bd_realstrategy(void *devdata, int rw, daddr_t dblk, size_t offset, > ^ > /scratch/tmp/bz/head.svn/sys/boot/pc98/libpc98/biosdisk.c:122:12: note: previous declaration is here > static int bd_realstrategy(void *devdata, int flag, daddr_t dblk, > ^ > 2 warnings and 4 errors generated. > --- biosdisk.o --- > *** [biosdisk.o] Error code 1 > > bmake[8]: stopped in /scratch/tmp/bz/head.svn/sys/boot/pc98/libpc98 > ===> usr.sbin/cron/crontab (all) > > — > Bjoern A. Zeeb Charles Haddon Spurgeon: > "Friendship is one of the sweetest joys of life. Many might have failed > beneath the bitterness of their trial had they not found a friend." > > Fixed in r298275, sorry I missed that one -- Allan Jude