From owner-dev-commits-src-all@freebsd.org Wed Jan 27 20:09:59 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2DDA74E8623; Wed, 27 Jan 2021 20:09:59 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DQvpb0lnFz3JV6; Wed, 27 Jan 2021 20:09:59 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 03F8E281CE; Wed, 27 Jan 2021 20:09:59 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f181.google.com with SMTP id r77so3030200qka.12; Wed, 27 Jan 2021 12:09:59 -0800 (PST) X-Gm-Message-State: AOAM533jetzEY0PWZ5CxtuRhjQOolwlNYRLcUi7rlSatThd4Ge6lw+fF 2YQjpk9qNrca9brvTLIBvfNOP3rhhJGvCFUXjTQ= X-Google-Smtp-Source: ABdhPJzZ7Og2v859vCq8F+8ycKrm4quOqUY+7VjBh7WIa1nKmme0S6pYDInusiUkbAq5SvPnp10/htS+wFiDjTxvmpU= X-Received: by 2002:a05:620a:5aa:: with SMTP id q10mr11822300qkq.103.1611778198515; Wed, 27 Jan 2021 12:09:58 -0800 (PST) MIME-Version: 1.0 References: <202101241941.10OJfCGA013081@gitrepo.freebsd.org> <20210124194640.GA6527@belenus.iks-jena.de> <76B5E43D-EB93-4739-BDD1-BECA4340CCDC@freebsd.org> In-Reply-To: <76B5E43D-EB93-4739-BDD1-BECA4340CCDC@freebsd.org> From: Kyle Evans Date: Wed, 27 Jan 2021 14:09:44 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 5fe433a6e4d8 - main - netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support To: Jessica Clarke Cc: John Baldwin , Lutz Donnerhacke , Lutz Donnerhacke , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2021 20:09:59 -0000 On Wed, Jan 27, 2021 at 1:59 PM Jessica Clarke wrote: > > On 27 Jan 2021, at 19:55, John Baldwin wrote: > > On 1/24/21 11:51 AM, Kyle Evans wrote: > >> On Sun, Jan 24, 2021 at 1:47 PM Lutz Donnerhacke wrote: > >> We switched up the recommendations[0][1] to advocate for what you've > >> done here ~2 weeks ago -- so yes, this is good. :-) > > > > Note that "Submitted by" may still be needed when there are multiple > > authors who contribute to a patch. (And I do kind of think pulling > > it from the template was a bit hasty as it didn't take those cases > > into account.) I do think we want Author to reflect the primary > > author of the change though. > > The git world (or at least the GitHub world) seems to be settling in > Co-authored-by: for that, which is more accurate. > Indeed, whoops- I hadn't thought of specifically noting something for co-authors. =-( I agree with switching to Co-authored-by; some tooling (e.g. GitHub, GitLab) will recognize this and do something appropriate with it if it can identify the coauthors. IMO "Submitted by" is an awkward verbiage for this, as "submitted" would (to me) typically imply the very specific action of presenting the patch and working it through the system (i.e. reviews), and these sets of people don't always match. That's getting pretty pedantic, but I suspect I'm not the only one that makes this kind of association and "co-authors" more clearly spells out how these individuals may be related w.r.t. any given patch in a more objective fashion. Thanks, Kyle Evans