From owner-cvs-all Tue May 14 18:19:57 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by hub.freebsd.org (Postfix) with ESMTP id 5BA6737B403 for ; Tue, 14 May 2002 18:19:44 -0700 (PDT) Received: (qmail 23183 invoked from network); 15 May 2002 01:19:42 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 15 May 2002 01:19:42 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4F1JfF62924; Tue, 14 May 2002 21:19:41 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020515065310.A64295@gsmx07.alcatel.com.au> Date: Tue, 14 May 2002 21:19:32 -0400 (EDT) From: John Baldwin To: Peter Jeremy Subject: Re: cvs commit: src/sys/boot/i386/boot2 boot2.c Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 14-May-2002 Peter Jeremy wrote: > On 2002-May-11 14:49:39 -0700, Peter Wemm wrote: >> Save about 60 bytes by #define memcpy __builtin_memcpy and removing >> the function we provided. Restore the Keyboard: yes/no printf for the >> probe diagnostics. We end up with 40 bytes free. > > More potential savings: > - Change dev_nm definition to "const char dev_nm[4][] = ..." saves 7 bytes. > This amounts to saving 20 bytes of pointers, but the code bloats by > 13 bytes because of reversion from register-indirect to direct addressing > of dev_nm in several places. (Using [3] instead of [4] actually makes > things worse because *3 isn't possible in the R/I/M byte). > - Change dev_maj defn to "const unsigned char dev_maj[]" saves 15 bytes. These and other changes suggested sound good to me. No objections from me if you commit them. > Peter -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message