From owner-svn-src-all@freebsd.org Wed Jan 30 14:47:47 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 31E1C14C2C1D; Wed, 30 Jan 2019 14:47:47 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 920BB6E4C7; Wed, 30 Jan 2019 14:47:46 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x0UEliuV013591; Wed, 30 Jan 2019 06:47:44 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x0UEliQq013590; Wed, 30 Jan 2019 06:47:44 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201901301447.x0UEliQq013590@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r343578 - in head/sys: dev/e1000 dev/ixgbe dev/ixl dev/vmware/vmxnet3 net In-Reply-To: <201901301321.x0UDLRGP027749@repo.freebsd.org> To: Marius Strobl Date: Wed, 30 Jan 2019 06:47:44 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 920BB6E4C7 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.975,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 14:47:47 -0000 > Author: marius > Date: Wed Jan 30 13:21:26 2019 > New Revision: 343578 > URL: https://svnweb.freebsd.org/changeset/base/343578 > > Log: > - Stop iflib(4) from leaking MSI messages on detachment by calling > bus_teardown_intr(9) before pci_release_msi(9). > - Ensure that iflib(4) and associated drivers pass correct RIDs to > bus_release_resource(9) by obtaining the RIDs via rman_get_rid(9) > on the corresponding resources instead of using the RIDs initially > passed to bus_alloc_resource_any(9) as the latter function may > change those RIDs. Solely em(4) for the ioport resource (but not > others) and bnxt(4) were using the correct RIDs by caching the ones > returned by bus_alloc_resource_any(9). > - Change the logic of iflib_msix_init() around to only map the MSI-X > BAR if MSI-X is actually supported, i. e. pci_msix_count(9) returns > > 0. Otherwise the "Unable to map MSIX table " message triggers for > devices that simply don't support MSI-X and the user may think that > something is wrong while in fact everything works as expected. > - Put some (mostly redundant) debug messages emitted by iflib(4) > and em(4) during attachment under bootverbose. The non-verbose > output of em(4) seen during attachment now is close to the one > prior to the conversion to iflib(4). > - Replace various variants of spelling "MSI-X" (several in messages) > with "MSI-X" as used in the PCI specifications. > - Remove some trailing whitespace from messages emitted by iflib(4) > and change them to consistently start with uppercase. > - Remove some obsolete comments about releasing interrupts from > drivers and correct a few others. > > Reviewed by: erj, Jacob Keller, shurd > Differential Revision: https://reviews.freebsd.org/D18980 MFC intentions? I am sure you mean to, just not sure how soon. Does this effect any of the PR's open against em(4)/iflib(9)? Thanks, Rod > > Modified: > head/sys/dev/e1000/if_em.c > head/sys/dev/e1000/if_em.h > head/sys/dev/ixgbe/if_ix.c > head/sys/dev/ixgbe/if_ixv.c > head/sys/dev/ixl/if_iavf.c > head/sys/dev/ixl/if_ixl.c > head/sys/dev/ixl/ixl_iw.c > head/sys/dev/ixl/ixl_pf_main.c > head/sys/dev/vmware/vmxnet3/if_vmx.c > head/sys/net/iflib.c > ... -- Rod Grimes rgrimes@freebsd.org