From owner-freebsd-bugs@FreeBSD.ORG Tue Nov 20 08:30:02 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F03A16A41A for ; Tue, 20 Nov 2007 08:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3DE9713C467 for ; Tue, 20 Nov 2007 08:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id lAK8U2IF009963 for ; Tue, 20 Nov 2007 08:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id lAK8U2Bl009960; Tue, 20 Nov 2007 08:30:02 GMT (envelope-from gnats) Resent-Date: Tue, 20 Nov 2007 08:30:02 GMT Resent-Message-Id: <200711200830.lAK8U2Bl009960@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Oleg Sharoiko Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E183916A418 for ; Tue, 20 Nov 2007 08:23:41 +0000 (UTC) (envelope-from os@brain.cc.rsu.ru) Received: from mail.r61.net (mail.r61.net [195.208.245.249]) by mx1.freebsd.org (Postfix) with ESMTP id 470F213C44B for ; Tue, 20 Nov 2007 08:23:40 +0000 (UTC) (envelope-from os@brain.cc.rsu.ru) Received: from brain.cc.rsu.ru (brain.cc.rsu.ru [195.208.252.154]) by mail.r61.net (8.14.1/8.14.1) with ESMTP id lAK7vxqd013407 for ; Tue, 20 Nov 2007 10:57:59 +0300 (MSK) (envelope-from os@brain.cc.rsu.ru) Received: from brain.cc.rsu.ru (localhost [127.0.0.1]) by brain.cc.rsu.ru (8.14.1/8.13.7) with ESMTP id lAK7vwet096646 for ; Tue, 20 Nov 2007 10:57:59 +0300 (MSK) (envelope-from os@brain.cc.rsu.ru) Received: (from os@localhost) by brain.cc.rsu.ru (8.14.1/8.13.7/Submit) id lAK7vwZX096645; Tue, 20 Nov 2007 10:57:58 +0300 (MSK) (envelope-from os) Message-Id: <200711200757.lAK7vwZX096645@brain.cc.rsu.ru> Date: Tue, 20 Nov 2007 10:57:58 +0300 (MSK) From: Oleg Sharoiko To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/118144: [patch] pam_lastlog doesn't check return values in pam_sm_close_session X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Oleg Sharoiko List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2007 08:30:02 -0000 >Number: 118144 >Category: bin >Synopsis: [patch] pam_lastlog doesn't check return values in pam_sm_close_session >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 20 08:30:01 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Oleg Sharoiko >Release: FreeBSD 6.2-STABLE i386 >Organization: >Environment: System: FreeBSD brain.cc.rsu.ru 6.2-STABLE FreeBSD 6.2-STABLE #0: Tue Sep 18 16:26:09 MSD 2007 os@brain.cc.rsu.ru:/usr/obj/usr/src/sys/brain.i386.RELENG_6.2007-04-14 i386 >Description: From lib/libpam/modules/pam_lastlog/pam_lastlog.c PAM_EXTERN int pam_sm_close_session(pam_handle_t *pamh __unused, int flags __unused, int argc __unused, const char *argv[] __unused) { const void *tty; pam_get_item(pamh, PAM_TTY, (const void **)&tty); if (strncmp(tty, _PATH_DEV, strlen(_PATH_DEV)) == 0) tty = (const char *)tty + strlen(_PATH_DEV); if (*(const char *)tty == '\0') return (PAM_SERVICE_ERR); if (logout(tty) != 1) syslog(LOG_ERR, "%s(): no utmp record for %s", __func__, (const char *)tty); logwtmp(tty, "", ""); return (PAM_SUCCESS); } 1. pam_get_item may fail 2. tty may be NULL resulting in SIGSEGV in strncmp. >How-To-Repeat: >Fix: --- pam_lastlog.c.orig Tue Nov 20 10:05:48 2007 +++ pam_lastlog.c Tue Nov 20 10:07:07 2007 @@ -170,9 +170,14 @@ pam_sm_close_session(pam_handle_t *pamh __unused, int flags __unused, int argc __unused, const char *argv[] __unused) { - const void *tty; + const void *tty = NULL; + int pam_err; - pam_get_item(pamh, PAM_TTY, (const void **)&tty); + pam_err = pam_get_item(pamh, PAM_TTY, (const void **)&tty); + if (pam_err != PAM_SUCCESS) + return (pam_err); + if (*tty == NULL) + return (PAM_SERVICE_ERR); if (strncmp(tty, _PATH_DEV, strlen(_PATH_DEV)) == 0) tty = (const char *)tty + strlen(_PATH_DEV); if (*(const char *)tty == '\0') >Release-Note: >Audit-Trail: >Unformatted: