From owner-p4-projects@FreeBSD.ORG  Wed Jun 21 13:13:36 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4A4CE16A479; Wed, 21 Jun 2006 13:13:36 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0E7CC16A47C;
	Wed, 21 Jun 2006 13:13:36 +0000 (UTC)
	(envelope-from flag@newluxor.wired.org)
Received: from mail.oltrelinux.com (krisma.oltrelinux.com [194.242.226.43])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 89D4743D45;
	Wed, 21 Jun 2006 13:13:35 +0000 (GMT)
	(envelope-from flag@newluxor.wired.org)
Received: from newluxor.wired.org (ip-79-107.sn1.eutelia.it [62.94.79.107])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.oltrelinux.com (Postfix) with ESMTP id C877311AEB8;
	Wed, 21 Jun 2006 15:13:34 +0200 (CEST)
Received: from newluxor.wired.org (localhost [127.0.0.1])
	by newluxor.wired.org (8.13.6/8.13.6) with ESMTP id k5LDD1MK002442;
	Wed, 21 Jun 2006 15:13:01 +0200 (CEST)
	(envelope-from flag@newluxor.wired.org)
Received: (from flag@localhost)
	by newluxor.wired.org (8.13.6/8.13.6/Submit) id k5LDD1hn002441;
	Wed, 21 Jun 2006 15:13:01 +0200 (CEST) (envelope-from flag)
Date: Wed, 21 Jun 2006 15:13:01 +0200
From: Paolo Pisati <p.pisati@oltrelinux.com>
To: Paolo Pisati <piso@freebsd.org>
Message-ID: <20060621131301.GA2419@tin.it>
References: <200606211214.k5LCETcv071167@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200606211214.k5LCETcv071167@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at krisma.oltrelinux.com
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 99751 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jun 2006 13:13:36 -0000

On Wed, Jun 21, 2006 at 12:14:29PM +0000, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=99751
> 
> Change 99751 by piso@piso_newluxor on 2006/06/21 12:14:00
> 
> 	Updated a bit to reflect work status
> 
> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/arm/arm/intr.c#2 edit
> .. //depot/projects/soc2006/intr_filter/notes#2 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/arm/arm/intr.c#2 (text+ko) ====
> 
> @@ -99,10 +99,9 @@
>  }
>  
>  void
> -arm_handler_execute(struct trapframe *frame, int irqnb)
> +arm_handler_execute(struct trapframe *frame, int irqnb __unused)
>  {
>  	struct intr_event *event;
> -	struct intr_handler *ih;
>  	struct thread *td = curthread;
>  	int i, thread;
>  
> @@ -115,14 +114,7 @@
>  			continue;
>  
>  		/* Execute fast handlers. */
> -		thread = 0;
> -		TAILQ_FOREACH(ih, &event->ie_handlers, ih_next) {
> -			if (!(ih->ih_flags & IH_FAST))
> -				thread = 1;
> -			else
> -				ih->ih_handler(ih->ih_argument ?
> -				    ih->ih_argument : frame);
> -		}
> +		thread = intr_filter_loop(event, frame);
>  
>  		/* Schedule thread if needed. */
>  		if (thread)
> 

For some reason, the server had this change pending, and
when i submitted an update to the todo list, this stale modification
crept in... the odd thing is that i was sure i commited it some
days ago...

-- 

Paolo

Piso's first law: nothing works as expected!