From owner-svn-src-head@FreeBSD.ORG Wed Jul 31 09:33:48 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D9CECEAD; Wed, 31 Jul 2013 09:33:48 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 99CA12601; Wed, 31 Jul 2013 09:33:48 +0000 (UTC) Received: from nine.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id C67BB4606; Wed, 31 Jul 2013 09:33:47 +0000 (UTC) Received: by nine.des.no (Postfix, from userid 1001) id F0BEB38DE3; Wed, 31 Jul 2013 11:33:51 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: obrien@freebsd.org Subject: Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng References: <201307292058.r6TKwA56031193@svn.freebsd.org> <86fvuwgrs6.fsf@nine.des.no> <20130730185034.GA63635@dragon.NUXI.org> Date: Wed, 31 Jul 2013 11:33:51 +0200 In-Reply-To: <20130730185034.GA63635@dragon.NUXI.org> (David O'Brien's message of "Tue, 30 Jul 2013 11:50:34 -0700") Message-ID: <86zjt3f4zk.fsf@nine.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jul 2013 09:33:48 -0000 "David O'Brien" writes: > Dag-Erling Sm=C3=B8rgrav writes: > > We've had a policy for several years now that all changes to the > > PRNG code in the kernel and libc must be reviewed by so@. > Where was this policy published or communicated? > There is no MAINTAINER line in sys/dev/random/, nor an entry in > /usr/src/MAINTAINERS. It is hard to follow some policy that cannot > be found. If it isn't adequately documented, then we need to look into that. It's not the only such case - jfv@'s hard lock on Intel NIC drivers isn't documented either. That doesn't mean we shouldn't enforce it. > This change does not change any of the PRNG algorithms. You know as well as I do that "I didn't change anything" is in the top five on the list of "programmers' famous last words". > Do you have any specific concerns? I don't have any major issues with the patch, but it should still have been submitted for pre-commit review. I have two minor issues: - The sysctl is currently a space-separated list with an extraneous leading space and a magic string (which contains separators) to indicate an empty list. At the very least, the leading space should be removed and the magic string should be changed to not include spaces; "none" should suffice. I would prefer a comma-separated list and an empty string to indicate an empty list. - The non-standard (at least in an IT context) spelling of "adapter". I'll try to get a second opinion within the day. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no