From owner-freebsd-stable@FreeBSD.ORG  Thu Jun  7 08:10:37 2012
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6B929106564A;
	Thu,  7 Jun 2012 08:10:37 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 5BE418FC16;
	Thu,  7 Jun 2012 08:10:35 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA16671;
	Thu, 07 Jun 2012 11:10:33 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1ScXnd-000CXk-Aq; Thu, 07 Jun 2012 11:10:33 +0300
Message-ID: <4FD061F8.6030905@FreeBSD.org>
Date: Thu, 07 Jun 2012 11:10:32 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:12.0) Gecko/20120503 Thunderbird/12.0.1
MIME-Version: 1.0
To: Jung-uk Kim <jkim@FreeBSD.org>
References: <1337319129.2915.4.camel@powernoodle-l7>
	<4FB6765A.2050307@FreeBSD.org>
	<1337710214.2916.8.camel@powernoodle-l7.corp.yahoo.com>
	<20120525163653.b61a08e2.lists@yamagi.org>
	<4FBFA9A9.7020806@FreeBSD.org> <4FBFBD39.7000105@FreeBSD.org>
	<4FBFDFFB.9020501@FreeBSD.org> <4FBFE624.1020208@FreeBSD.org>
	<20120526090233.f638c1d2.lists@yamagi.org>
	<4FC0A3A1.80200@FreeBSD.org> <4FC7D464.20602@FreeBSD.org>
	<4FCFD2A1.60706@FreeBSD.org> <4FCFE178.9080505@FreeBSD.org>
In-Reply-To: <4FCFE178.9080505@FreeBSD.org>
X-Enigmail-Version: 1.5pre
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: sbruno@FreeBSD.org, freebsd-acpi@FreeBSD.org, freebsd-stable@FreeBSD.org,
	Yamagi Burmeister <lists@yamagi.org>, seanbru@yahoo-inc.com
Subject: Re: [stable 9] broken hwpstate calls
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jun 2012 08:10:37 -0000

on 07/06/2012 02:02 Jung-uk Kim said the following:
> Any way, hwpstate still isn't quite right even without your patch.
> 
> sys/kern/kern_cpu.c cpufreq_curr_sysctl() -> CPUFREQ_SET() ->	/* for all
> CPU devices */ cf_set_method() ->	/* thread_lock(), sched_bind(), ... */ 
> CPUFREQ_DRV_SET() -> sys/x86/cpufreq/hwpstate.c hwpstate_set() -> 
> hwpstate_goto_pstate()	/* for each CPU unit */ /* thread_lock(),
> sched_bind(), ... */

Oh, I didn't realize that there was the cpufreq-level loop over all CPUs!
That really sucks.

Maybe some day we should accept that different CPUs could legitimately be in
different P-states and provide support for that throughout the stack (from
powerd to drivers).

-- 
Andriy Gapon