Date: Thu, 20 Apr 2017 23:12:34 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 218784] databases/rocksdb: remove no-op, fix LITE cflags Message-ID: <bug-218784-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218784 Bug ID: 218784 Summary: databases/rocksdb: remove no-op, fix LITE cflags Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: sunpoet@FreeBSD.org Reporter: lx@FreeBSD.org Assignee: sunpoet@FreeBSD.org Flags: maintainer-feedback?(sunpoet@FreeBSD.org) Created attachment 181959 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D181959&action= =3Dedit Remove CPPFLAGS, change to CFLAGS After some functional testing, it looks like the current RocksDB isn't hono= ring CPPFLAGS. This makes the CPPFLAGS+=3D -DOS_FREEBSD a no-op, which is fine b= ecause cmake now defines that on its own. It also means that the CPPFLAGS+=3D -DROCKSDB_LITE=3D1 isn't getting honored. This diff removes the first CPPFLAGS line, and changes the latter one to use CFLAGS instead, which correctly builds the lite version (verified by checki= ng the symbols). Both regular and -lite poudriere correctly. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-218784-13>