From owner-cvs-all@FreeBSD.ORG  Tue Mar 18 18:15:46 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id D307E1065673; Tue, 18 Mar 2008 18:15:46 +0000 (UTC)
Date: Tue, 18 Mar 2008 18:15:46 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Stanislav Sedov <stas@FreeBSD.org>
Message-ID: <20080318181546.GA10903@FreeBSD.org>
References: <200803180100.m2I10QTD070047@repoman.freebsd.org>
	<20080318193855.0439b197.stas@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20080318193855.0439b197.stas@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Pietro Cerutti <gahr@FreeBSD.org>
Subject: Re: cvs commit: ports/java/eclipseme Makefile distinfo pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Mar 2008 18:15:47 -0000

On Tue, Mar 18, 2008 at 07:38:55PM +0300, Stanislav Sedov wrote:
> On Tue, 18 Mar 2008 01:00:26 +0000 (UTC)
> Pietro Cerutti <gahr@FreeBSD.org> mentioned:
> 
> > gahr        2008-03-18 01:00:26 UTC
> > 
> >   FreeBSD ports repository
> > 
> >   Modified files:
> >     java/eclipseme       Makefile distinfo pkg-plist 
> >   Log:
> >   - Update to 0.4.6
> >   
> >   Approved by:    miwi (mentor)
> >   
> >   Revision  Changes    Path
> >   1.6       +5 -8      ports/java/eclipseme/Makefile
> > http://cvsweb.FreeBSD.org/ports/java/eclipseme/Makefile.diff?r1=1.5&r2=1.6
> > | --- ports/java/eclipseme/Makefile	2007/07/16 08:58:28	1.5
> > | +++ ports/java/eclipseme/Makefile	2008/03/18 01:00:25	1.6
> > | @@ -2,15 +2,13 @@
> > |  # Date created:				July 22, 2004
> > |  # Whom:					past@ebs.gr
> > |  #
> > | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/java/eclipseme/Makefile,v 1.5 2007/07/16 08:58:28 pav Exp $
> > | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/java/eclipseme/Makefile,v 1.6 2008/03/18 01:00:25 gahr Exp $
> > |  #
> > |  
> > |  PORTNAME=	eclipseme
> > | -PORTVERSION=	0.4.5
> > | -PORTREVISION=	3
> > | +PORTVERSION=	0.4.6
> > |  CATEGORIES=	java devel
> > | -MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
> > | -MASTER_SITE_SUBDIR=	${PORTNAME}
> > | +MASTER_SITES=	SF
> > |  DISTNAME=	${PORTNAME}-${PORTVERSION}
> > |  DIST_SUBDIR=	eclipse
> > |  
> > | @@ -31,11 +29,10 @@ RUN_DEPENDS+=	${LOCALBASE}/share/proguar
> > |  .endif
> > |  
> > |  do-install:
> > | -		@${CP} -r ${WRKSRC}/${PORTNAME}_${PORTVERSION} ${PREFIX}/eclipse/plugins/
> > | +	@${MKDIR} ${PREFIX}/eclipse/plugins
> > | +	@${CP} -r ${WRKSRC}/${PORTNAME}_${PORTVERSION} ${PREFIX}/eclipse/plugins/
> 
> Wouldn't it be better to use COPYTREE_SHARE for that? This way it'll set correct
> permissions on files.

Not to mention that -R should've probably be used instead or -r, and we
generally try not to mute installation of files/links (as opposed to
dirs).

./danfe