From owner-svn-ports-all@freebsd.org Mon Jan 1 23:18:14 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEE35E8A830; Mon, 1 Jan 2018 23:18:14 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [78.47.246.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6F7DC3454; Mon, 1 Jan 2018 23:18:13 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id w01NHwub003510 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 2 Jan 2018 00:17:59 +0100 (CET) (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: dim@FreeBSD.org Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id w01NHl1x074870 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 2 Jan 2018 06:17:47 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: svn commit: r457814 - in head/sysutils/smartmontools: . files To: Dimitry Andric , samm@os2.kiev.ua, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201801012119.w01LJXE9054540@repo.freebsd.org> From: Eugene Grosbein Message-ID: <5A4AC199.7070400@grosbein.net> Date: Tue, 2 Jan 2018 06:17:45 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <201801012119.w01LJXE9054540@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.2 required=5.0 tests=BAYES_00, LOCAL_FROM, RDNS_NONE autolearn=no autolearn_force=no version=3.4.1 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 1.9 RDNS_NONE Delivered to internal network by a host with no rDNS * 2.6 LOCAL_FROM From my domains X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on hz.grosbein.net X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jan 2018 23:18:15 -0000 02.01.2018 4:19, Dimitry Andric пишет: > Author: dim (src committer) > Date: Mon Jan 1 21:19:33 2018 > New Revision: 457814 > URL: https://svnweb.freebsd.org/changeset/ports/457814 > > Log: > Make smartmontools 6.6 compile with clang 6.0.0 and higher > > Because clang 6.0.0 and higher default to -std=gnu++14, like gcc 6 and > higher, compiling smartmontools results in the following error: > > os_freebsd.cpp:487:45: error: invalid suffix on literal; C++11 requires > a space between literal and identifier [-Wreserved-user-defined-literal] > else if (sscanf(dev, NVME_CTRLR_PREFIX"%d"NVME_NS_PREFIX"%d%c", > ^ > > Fix this by adding spaces around the NVME_NS_PREFIX macro. This makes > the source C++14 compatible. > > Approved by: samm@os2.kiev.ua (maintainer) > PR: 224826 > MFH: 2018Q1 Why don't you just modify CFLAGS to set -std=... to right mode corresponding to current coding style of smartmontools instead?