From owner-freebsd-ports Sun Jul 14 7:17: 6 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91C6A37B400 for ; Sun, 14 Jul 2002 07:16:59 -0700 (PDT) Received: from smtp.noos.fr (descartes.noos.net [212.198.2.74]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8651343E65 for ; Sun, 14 Jul 2002 07:16:58 -0700 (PDT) (envelope-from root@gits.dyndns.org) Received: (qmail 51371264 invoked by uid 0); 14 Jul 2002 14:16:49 -0000 Received: from unknown (HELO gits.gits.dyndns.org) ([212.198.229.153]) (envelope-sender ) by 212.198.2.74 (qmail-ldap-1.03) with SMTP for ; 14 Jul 2002 14:16:49 -0000 Received: from gits.gits.dyndns.org (xtczbz27gfneuwln@localhost [127.0.0.1]) by gits.gits.dyndns.org (8.12.5/8.12.5) with ESMTP id g6EEGmdT064470; Sun, 14 Jul 2002 16:16:48 +0200 (CEST) (envelope-from root@gits.dyndns.org) Received: (from root@localhost) by gits.gits.dyndns.org (8.12.5/8.12.5/Submit) id g6EEGlUR064469; Sun, 14 Jul 2002 16:16:47 +0200 (CEST) (envelope-from root) Date: Sun, 14 Jul 2002 16:16:47 +0200 From: Cyrille Lefevre To: Alexander Leidinger Cc: freebsd-ports@FreeBSD.ORG Subject: Re: ports/39606: Updated port: audio/lame (3.92) Message-ID: <20020714141647.GA64406@gits.dyndns.org> Mail-Followup-To: Cyrille Lefevre , Alexander Leidinger , freebsd-ports@FreeBSD.ORG References: <20020714122659.GF35142@gits.dyndns.org> <200207141254.g6ECsUxQ097775@Magelan.Leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200207141254.g6ECsUxQ097775@Magelan.Leidinger.net> User-Agent: Mutt/1.3.99i Organization: ACME X-Face: V|+c;4!|B?E%BE^{E6);aI.[< List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sun, Jul 14, 2002 at 02:54:30PM +0200, Alexander Leidinger wrote: > On 14 Jul, Cyrille Lefevre wrote: > > >> Do we really need vorbis support in LAME? The support was intended to > >> have a command line utility at a time where vorbis hadn't a good command > >> line utility. > > > > don't know, but since the code may support it, I left the choice > > to users. in other words, I hate incomplete ports... but, if you > > want to get rid of vorbis support, no problem. > > I think we should at least make it off by default... done. > >> >> +USE_GMAKE= yes > >> > >> It doesn't neet gmake. > > > > as a general rule, I always add USE_GMAKE in conjunction of > > GNU_CONFIGURE because, sometimes, not everything is build > > w/ a legacy make. I already got this issue w/ some ports > > (don't remember they names), so, I prefer to prevent this > > as a side rule. > > The actual automake does a good job in this case. I only had once > problems without gmake. I can assure you that LAME builds with our make > successfully (I'm responsible for the auto* stuff in LAME). done but since you are responsible for the auto* stuff in LAME, I prefer you add support yourself for --with-vorbis-src rather than me because I have a low knowledge of auto* things :) > >> >> +install-la: > >> >> + @${INSTALL_SCRIPT} ${WRKSRC}/libmp3lame/libmp3lame.la ${PREFIX}/lib > >> > >> We don't need the .la file. > > > > well, I'm just doing what's other ports do. > > Only ports which depend on the new libtool do this. We try to not > install the .la files. done. Index: /usr/ports/audio/lame/Makefile =================================================================== RCS file: /home/ncvs/ports/audio/lame/Makefile,v retrieving revision 1.21 diff -u -r1.21 Makefile --- /usr/ports/audio/lame/Makefile 22 Apr 2002 01:22:48 -0000 1.21 +++ /usr/ports/audio/lame/Makefile 14 Jul 2002 14:14:12 -0000 @@ -6,40 +6,77 @@ # PORTNAME= lame -PORTVERSION= 3.91 +PORTVERSION= 3.92 CATEGORIES= audio MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} \ - ftp://lame.sourceforge.net/pub/ + ftp://ftp.fu-berlin.de/unix/sound/%SUBDIR%/ MASTER_SITE_SUBDIR= lame MAINTAINER= yoshiaki@kt.rim.or.jp BUILD_DEPENDS= nasm:${PORTSDIR}/devel/nasm +.if defined(WITH_VORBIS) +LIB_DEPENDS= vorbis.1:${PORTSDIR}/audio/libvorbis + +# libvorbis sources are required wether or not the library is already installed. +DEPENDS= ${PORTSDIR}/audio/libvorbis:patch +.endif + GNU_CONFIGURE= yes INSTALLS_SHLIB= yes +USE_LIBTOOL= yes WANT_GTK= yes -CONFIGURE_ARGS= --enable-nasm +CONFIGURE_ARGS= --enable-nasm --enable-mp3rtp + +MAN1= lame.1 .include -.if (defined(HAVE_GTK) || defined(WITH_GTK)) && !defined(WITHOUT_GTK) +.if defined(HAVE_GTK) USE_GTK= yes PLIST_SUB+= WITH_GTK='' +CONFIGURE_ARGS+= --enable-mp3x .else PLIST_SUB+= WITH_GTK='@comment ' +CONFIGURE_ARGS+= --disable-gtktest .endif -MAN1= lame.1 +.if defined(WITH_VORBIS) +LIBVORBIS_SRC!= cd ${PORTSDIR}/audio/libvorbis && ${MAKE} -V WRKSRC -post-build: -.if defined(HAVE_GTK) && !defined(WITHOUT_GTK) - (cd ${WRKSRC}/frontend && make mp3x) +CONFIGURE_ARGS+= --with-vorbis +CONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include -I${LIBVORBIS_SRC}/lib" \ + LDFLAGS="-L${LOCALBASE}/lib" \ + LIBS=-logg .endif -post-install: -.if defined(HAVE_GTK) && !defined(WITHOUT_GTK) - ${INSTALL_PROGRAM} ${WRKSRC}/frontend/mp3x ${PREFIX}/bin/ +DOC_FILES= API LICENSE PRESETS.draft README TODO USAGE + +pre-everything:: +.if !defined(WITH_VORBIS) + @${ECHO_MSG} + @${ECHO_MSG} "If you want to compile with Vorbis support." + @${ECHO_MSG} "hit Ctrl-C right now and use \"make WITH_VORBIS=yes\"" + @${ECHO_MSG} +.endif + +.if defined(NOPORTDOCS) +do-install: + @cd ${INSTALL_WRKSRC} && ${SETENV} ${MAKE_ENV} ${GMAKE} \ + ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} install-exec + @cd ${INSTALL_WRKSRC}/include && ${SETENV} ${MAKE_ENV} ${GMAKE} \ + ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} install-data + @cd ${INSTALL_WRKSRC}/doc/man && ${SETENV} ${MAKE_ENV} ${GMAKE} \ + ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} install-data +.else +post-install: install-doc + +install-doc: + @${MKDIR} ${DOCSDIR} +.for file in ${DOC_FILES} + @${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR} +.endfor .endif .include Cyrille. -- Cyrille Lefevre mailto:cyrille.lefevre@laposte.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message