From nobody Wed Mar 5 16:52:57 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z7JX16zYbz5qRkm; Wed, 05 Mar 2025 16:53:05 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z7JX16FyQz3xr0; Wed, 05 Mar 2025 16:53:05 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741193585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2UtAkrk5T0aS3W3MVvP+mJfoE/3Raf4EAoHXVJ+vbKo=; b=BmTNm2HZaOq0Db0hBjbl6NEjuar65R4ZOvNKv2Doh1Gj96ySaeD3fSxc1yydiX7IbQSVCD cKaWHv8XPVw/fzVGG+TxWtPk5oOlCseoFVKWjJhG7zeBzwLXypSndwp1mrDgB7DcaWaUcV kKowfWnLy4kdIjrLN3FM9UpwQmI+jL5bxUQEKo9PaSBmAf7zgNPTlHxjVgkvItO5JGrseF k8EgTyHa8iwivCE9Nf2soNxl2QWg2EdjKfT7CsLEH3os5+S2A3R07S7hrL6PJdZ71c8lVY QFnlZYNWdwT5GRKKydeV9unjPWQ4qqgcs/aK1ZNVzVYbSAutVDFEVeLy16+dMw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741193585; a=rsa-sha256; cv=none; b=a13i3XRoVlDo0FwqQ1w8MXMXFOZo2BZw5WVNeiEHuOpNSPntwOTyf90KjmCSYNrhwoKlNo ByxrSjTyPtmQv2kAn8qUAlfezW0xmLezeiYTDBdLuwdU23cqUTSDX8F1QRQn6oFWvnXpm4 KuiZQh3e4vQUqNVbaM7fl02YLY2nEHxCyYO++W9WowSV7uvvyfGhMLTwKJoRvja1gs5kIv DhOgtrjrAEnJeYVCOeFooLz9DXLllP1/XNeDHY5Nk0bFEo6Y51LFXE+uPWOVL5ABce16/P tr4nvAJ+Uf+MiUbPI6OSLBpjdazw93sW1zWfousoFOtqzE2YSRcE0bZEayCngg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741193585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2UtAkrk5T0aS3W3MVvP+mJfoE/3Raf4EAoHXVJ+vbKo=; b=gypEe1XjelfHQGRwh6yhb1bR6RWSAOHgpUoZG8r1JCud7SkgoAMXKMZRfEfHSiH+epqljC E/qph/PG0ZsVidlcqNFfqoZCO6gO6f7obf7fiJWYvOuktxCYTjZOP88ELQ4nISaNigm98a C+MpZBbbLC0oIPAfLslaWw9A9IyLeRj3eeXoD7+M8230fUWMCqCIwLSR/yPtM2e/rV2Jvm tZ0t7GWjnnXwR/cdo/oI42bqkFE3ShfE5HpYze79DLDwpIxsBhgEytop0mfA0QbTZHrs8B CqTcx6HGCAmyieRF+I0su3FVp9VOwO4HVwNFzCG8/he6cIpI1y3y1Zip6FQ6RA== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R10" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z7JX14yfXzDdv; Wed, 05 Mar 2025 16:53:05 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id EFD902875D; Wed, 05 Mar 2025 17:53:02 +0100 (CET) From: Kristof Provost To: Gleb Smirnoff Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7e51bc6cdd5c - main - pf: Introduce unhandled_af() Date: Wed, 05 Mar 2025 17:52:57 +0100 X-Mailer: MailMate (2.0r6222) Message-ID: In-Reply-To: References: <202503040805.52485pYn088632@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; markup=markdown Content-Transfer-Encoding: quoted-printable On 5 Mar 2025, at 17:43, Gleb Smirnoff wrote: > On Tue, Mar 04, 2025 at 08:05:51AM +0000, Kristof Provost wrote: > K> The branch main has been updated by kp: > K> > K> URL: https://cgit.FreeBSD.org/src/commit/?id=3D7e51bc6cdd5c317109e25= b0b64230d00d68dceb3 > K> > K> commit 7e51bc6cdd5c317109e25b0b64230d00d68dceb3 > K> Author: Kristof Provost > K> AuthorDate: 2025-03-03 16:26:39 +0000 > K> Commit: Kristof Provost > K> CommitDate: 2025-03-04 08:05:37 +0000 > K> > K> pf: Introduce unhandled_af() > K> > K> For cases where code conditionally does something based on an ad= dress family > K> and later assumes one of the paths was taken. This was initiall= y just calls > K> to panic until guenther suggested a function to reduce the amoun= t of strings > K> needed. > K> > K> This reduces the amount of noise with static analysers and acts = as a sanity > K> check. > K> > K> ok guenther@ bluhm@ > K> > K> Obtained from: OpenBSD, jsg , ba4138390b > K> Sponsored by: Rubicon Communications, LLC ("Netgate") > > Heh, enum solves the problem at compilation time. I will try to revisi= t the review > that had this idea. > Oh yeah, I=E2=80=99d forgotten about that one. In any event, this is useful as a diff-reduction exercise, if nothing els= e. I=E2=80=99m hoping to be able to continue importing OpenBSD patches, b= ut there=E2=80=99s still a very long way to go before we=E2=80=99re all t= he way caught up. And even if/when we get there there=E2=80=99ll still be a substantial del= ta, because we don=E2=80=99t want to drop support for older syntax in the= way OpenBSD has, and we want to keep stuff like your multicore work and = the vnet support. And the SCTP support. And the basic Ethernet support. Anyway, lots of random thoughts to say: that=E2=80=99d be nice to have, b= ut certainly isn=E2=80=99t urgent. Best regards, Kristof