From owner-svn-src-all@FreeBSD.ORG  Mon Feb 23 08:25:05 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DA134106566B;
	Mon, 23 Feb 2009 08:25:05 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121])
	by mx1.freebsd.org (Postfix) with ESMTP id EE5308FC14;
	Mon, 23 Feb 2009 08:25:04 +0000 (UTC) (envelope-from mav@FreeBSD.org)
X-Spam-Flag: SKIP
X-Spam-Yversion: Spamooborona-2.1.0
Received: from orphanage.alkar.net (account mav@alkar.net [212.86.226.11]
	verified) by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9)
	with ESMTPA id 235492778; Mon, 23 Feb 2009 10:25:03 +0200
Message-ID: <49A25D5F.4080402@FreeBSD.org>
Date: Mon, 23 Feb 2009 10:25:03 +0200
From: Alexander Motin <mav@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.14 (X11/20080612)
MIME-Version: 1.0
To: Gavin Atkinson <gavin@FreeBSD.org>
References: <200902221408.n1ME8K6n098261@svn.freebsd.org>
	<20090223080900.Q86550@ury.york.ac.uk>
In-Reply-To: <20090223080900.Q86550@ury.york.ac.uk>
X-Enigmail-Version: 0.95.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r188918 - head/sys/dev/ata/chipsets
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2009 08:25:06 -0000

Gavin Atkinson wrote:
> On Sun, 22 Feb 2009, Alexander Motin wrote:
> 
>> Author: mav
>> Date: Sun Feb 22 14:08:20 2009
>> New Revision: 188918
>> URL: http://svn.freebsd.org/changeset/base/188918
>>
>> Log:
>>  Tune AHCI verbose messages to make log more readable.
>>
> [snip]
>> @@ -665,9 +670,10 @@ ata_ahci_softreset(device_t dev, int por
>>     //ctp->cfis[7] = ATA_D_LBA | ATA_D_IBM;
>>     ctp->cfis[15] = (ATA_A_4BIT | ATA_A_RESET);
>>
>> -    if (ata_ahci_issue_cmd(dev, ATA_AHCI_CMD_RESET |
>> ATA_AHCI_CMD_CLR_BUSY,100))
>> -    device_printf(dev, "setting SRST failed ??\n");
>> -    //return -1;
>> +    if (ata_ahci_issue_cmd(dev, ATA_AHCI_CMD_RESET |
>> ATA_AHCI_CMD_CLR_BUSY,100)) {
>> +    device_printf(dev, "software reset set timeout\n");
>> +    return (-1);
>> +    }
>>
> 
> Was the uncommenting of the return intentional here?  Before, the code
> would continue to clear the soft reset even if it didn't appear to have
> worked.

It was. It shouldn't happen now. Linux does the same.

>> @@ -767,11 +778,11 @@ ata_ahci_reset(device_t dev)
>>     break;
>>     default: /* SOS XXX */
>>     if (bootverbose)
>> -        device_printf(dev, "No signature, asuming disk device\n");
>> +        device_printf(dev, "Unknown signature, asuming disk device\n");
>>     ch->devices = ATA_ATA_MASTER;
>>     }
> 
> Spelling is wrong here (and was before you changed it too): should be
> "assuming" not "asuming"

Thanks! Fixed.

-- 
Alexander Motin