From nobody Thu May 15 13:07:47 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zyr9H3Xwpz5wKQD; Thu, 15 May 2025 13:07:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zyr9H2r9kz3l85; Thu, 15 May 2025 13:07:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747314467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AaxkLdAuOFgHujv7MSuCF9n9YMiIGsTffuPEOScVvTc=; b=qioVSuqANARkziFfijMBhWeRit9boawfaAV3KUJukLQgOnyCY0YGRhbxFXyFyZ/wMhpmU9 wSGNnEKH8JYZDdjwMuXnfh0nzaBkhMB6ULtpJcc2XcYWO/RkIOldyZ35/W574olDBa1XXc sfgHg48QWwQtchSnelSRXNfzlIuziJArKA9HTlgeBiG0RWt6VqkEaSlQ6jR4h9AvuzlfY1 c7c3YVhMGdjkD0TbqDxZmmcAiJtTkMAr/0OMS6k0gAQeeFvVprxVgP3X1eNzxLO3n8Xtw6 HWBY0YRe6xmwkJkhj5LrvRPst3dphumkp4atx/XGQxV32sztLBeBVWIeSjaQHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747314467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AaxkLdAuOFgHujv7MSuCF9n9YMiIGsTffuPEOScVvTc=; b=F6+NGlCFH4Mz9a0yrmMYjqp/b9Awk1KcMVNQ7KffB/gg0NJy3nnvBzIuPTkux+UbcITCe6 7ZS1/zDZFUE+rqR1u/nzT/Bli+QiZO4zsLZ14pYwaSCjnrVP5TLvOUNf6FBNHyl0ob3hVa Qa6xZa665G5Bl6QF33wLSj8THs1RbK0hZl+bQfVWJxbI/ivIvdz0MY8wtcBu/rR32AmnGD bshXiMwtK4DI9SpDl6ONQSxZhu2H9SvXEAOjgKyYuWGQ1fUCndN5k7W6sQU+Vt5+D4X1/L Uq15hmJ5fzEfOWWuP1NCK9zrrkKtTZRTOz17IsAE9+r4oIO88HgqUNV/GQYhqA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747314467; a=rsa-sha256; cv=none; b=BGJBETpTjpMeGWAE/wBP4ubc0AmxQcv/A6Pd3Sl4kpnhkxUc1CEPHiJhBQ7acW+BpmMQCM uiLq7UBsDl7GmoKfRk2nDl5lqjzV5zKkGyj0DR5ccyIi5OZB0NedQrO+xLfIEqTZ5Gc6Wl ygrdxMQMNSJ/POY7vjU44YZr1EKfN6ilfVYcewzl3DvSQhX4lBBT03zF+eoHNuvdNLa7d4 LJc8EwSaRNNR8yZU/w+FOQn4nwO8QzSK+hc6tK7RVBLT7TlxwtZqb6mscZs82vHoBOnCgl sAHF3pPT1vbYYMV1oyFBRdguH5S0tvG/XsUi6vbXM/Kg+KRUo9Him9yJOfPJyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zyr9H2MYMz3bq; Thu, 15 May 2025 13:07:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54FD7lPr008980; Thu, 15 May 2025 13:07:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54FD7lnq008977; Thu, 15 May 2025 13:07:47 GMT (envelope-from git) Date: Thu, 15 May 2025 13:07:47 GMT Message-Id: <202505151307.54FD7lnq008977@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Justin Hibbits Subject: git: ac1943f97c01 - releng/14.3 - powerpc: Always use BE tag in nexus_map_resource List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhibbits X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.3 X-Git-Reftype: branch X-Git-Commit: ac1943f97c01b0ef049a9bfd81cf2b4a05d0a9d9 Auto-Submitted: auto-generated The branch releng/14.3 has been updated by jhibbits: URL: https://cgit.FreeBSD.org/src/commit/?id=ac1943f97c01b0ef049a9bfd81cf2b4a05d0a9d9 commit ac1943f97c01b0ef049a9bfd81cf2b4a05d0a9d9 Author: Justin Hibbits AuthorDate: 2025-05-13 01:35:14 +0000 Commit: Justin Hibbits CommitDate: 2025-05-15 13:06:51 +0000 powerpc: Always use BE tag in nexus_map_resource 7b5a5e4e replaced nexus_activate_resource() with the bus generic equivalent, which uses bus_map_resource(). However, though not intended to have a functional change, nexus_map_resource() uses the bus tag of the build (BE vs LE), while nexus_activate_resource() always explicitly set a big-endian tag, leading to failures on powerpc64le now. Using BE unless otherwise explicitly specified with the RF_LITTLEENDIAN fixes LE on bare metal, and doesn't hurt in a VM, which nexus_map_resource() was added for. Reported by: pkubaj Tested by: pkubaj Fixes: 7b5a5e4e("powerpc nexus: Use bus_generic_rman_*") MFC after: 1 day Approved by: re(cperciva) (cherry picked from commit c4921a0faaf1683f39347dd066000d929c39c8b9) (cherry picked from commit 45d585ab7f222ca36988c406df528128a17f9884) --- sys/powerpc/powerpc/nexus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/powerpc/powerpc/nexus.c b/sys/powerpc/powerpc/nexus.c index 826e75daa374..b40bb26fd395 100644 --- a/sys/powerpc/powerpc/nexus.c +++ b/sys/powerpc/powerpc/nexus.c @@ -289,7 +289,7 @@ nexus_map_resource(device_t bus, device_t child, int type, struct resource *r, if ((rman_get_flags(r) & RF_LITTLEENDIAN) != 0) map->r_bustag = &bs_le_tag; else - map->r_bustag = nexus_get_bus_tag(NULL, NULL); + map->r_bustag = &bs_be_tag; map->r_size = length; map->r_bushandle = (bus_space_handle_t)map->r_vaddr; break;