From owner-svn-ports-all@freebsd.org  Sun Mar 12 12:05:33 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3EC7D089A6;
 Sun, 12 Mar 2017 12:05:33 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B448F138C;
 Sun, 12 Mar 2017 12:05:33 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 12F4C969; Sun, 12 Mar 2017 12:05:33 +0000 (UTC)
Date: Sun, 12 Mar 2017 12:05:33 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Matthew Rezny <rezny@freebsd.org>
Cc: Adam Weinberger <adamw@adamw.org>, Tijl Coosemans <tijl@freebsd.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org, swills@freebsd.org, gnome@freebsd.org
Subject: Re: svn commit: r435961 - in head/www/webkit-gtk2: . files
Message-ID: <20170312120533.GA43736@FreeBSD.org>
References: <201703112115.v2BLF3qk062113@repo.freebsd.org>
 <1651531.nGg9pBWiG5@workstation.reztek>
 <96D05335-EC74-4CD0-9F00-95CC02B62CF8@adamw.org>
 <6528743.Wv2563vc2k@workstation.reztek>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6528743.Wv2563vc2k@workstation.reztek>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Mar 2017 12:05:33 -0000

On Sun, Mar 12, 2017 at 03:10:09AM +0100, Matthew Rezny wrote:
> Many ports that use gnutls produce warnings from stage-qa because gnutls
> depends on libgcrypt which depends on libgpg-error, and while I sometime
> see libgcrypt alongside gnutls, I rarely notice libgpg-error alongside
> either, and I find myself frequently adding both. [...]
> 
> Should every port using libgcrypt have to depend on libgpg-error when
> libgcrypt already depends on it, or is the stage-qa check over aggressive?

`Mk/Scripts/qa.sh' is doing what it can: that is, what readelf(1) tells
it.  Technically no, not every port using libgcrypt has to depend on
libgpg-error, as long as you link with -lgcrypt only and it's sufficient.
However, libgpg-error is pulled by default via libgcrypt's config script:

    $ /usr/local/bin/libgcrypt-config --libs
    -L/usr/local/lib -lgcrypt -lgpg-error

I'd guess this are just safest default so your program surely links if
you use functions from any (or both) libraries, so even when this is not
the case both libraries would be pulled if author (or maintainer) does
not pay attention.  Another approach is to use -Wl,--as-needed option;
some GNU/Linux distros' toolchains even enable it by default, but I'd
leave that to someone more knowledgeable to talk about.

./danfe