From owner-cvs-all  Tue May 21 15:16:59 2002
Delivered-To: cvs-all@freebsd.org
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by hub.freebsd.org (Postfix) with ESMTP
	id E929B37B406; Tue, 21 May 2002 15:16:55 -0700 (PDT)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id BE7CAAE162; Tue, 21 May 2002 15:16:55 -0700 (PDT)
Date: Tue, 21 May 2002 15:16:55 -0700
From: Alfred Perlstein <bright@mu.org>
To: John Baldwin <jhb@FreeBSD.org>
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org,
	"Andrew R. Reiter" <arr@FreeBSD.org>
Subject: Re: cvs commit: src/sys/kern uipc_socket.c
Message-ID: <20020521221655.GM54960@elvis.mu.org>
References: <20020521213720.GL54960@elvis.mu.org> <XFMail.20020521180307.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <XFMail.20020521180307.jhb@FreeBSD.org>
User-Agent: Mutt/1.3.27i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

* John Baldwin <jhb@FreeBSD.org> [020521 15:03] wrote:
> 
> On 21-May-2002 Alfred Perlstein wrote:
> > * Andrew R. Reiter <arr@FreeBSD.org> [020521 14:18] wrote:
> >> arr         2002/05/21 14:18:41 PDT
> >> 
> >>   Modified files:
> >>     sys/kern             uipc_socket.c 
> >>   Log:
> >>   - OR the flag variable with M_ZERO so that the uma_zalloc() handles the
> >>     zero'ing out of the allocated memory.  Also removed the logical bzero
> >>     that followed.
> > 
> > This is just making something wrong prettier as well as obfuscating
> > the problem and making the XXX comment not make sense.
> 
> The XXX already didn't make sense.  Why do you prefer explicit bzero()
> to M_ZERO?

The XXX made sense if you understand how the gencounts are used to
detect out of date sockets when copying out statistics into userland.

I don't prefer bzero over M_ZERO, I prefer him using the UMA callbacks
to _properly_ bzero only the parts of the socket that need it.

-Alfred

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message