From owner-cvs-all@FreeBSD.ORG Thu Aug 31 05:51:59 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7889A16A4DD; Thu, 31 Aug 2006 05:51:59 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2BECA43D53; Thu, 31 Aug 2006 05:51:59 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id B864D46B9D; Thu, 31 Aug 2006 01:51:58 -0400 (EDT) Date: Thu, 31 Aug 2006 06:51:58 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Warner Losh In-Reply-To: <200608281726.k7SHQdhJ045742@repoman.freebsd.org> Message-ID: <20060831064831.K81771@fledge.watson.org> References: <200608281726.k7SHQdhJ045742@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/openbsm - Imported sources X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2006 05:51:59 -0000 On Mon, 28 Aug 2006, Warner Losh wrote: > imp 2006-08-28 17:26:39 UTC > > FreeBSD src repository > > src/contrib/openbsm - Imported sources > Update of /home/ncvs/src/contrib/openbsm > In directory repoman.freebsd.org:/tmp/cvs-serv45632 > > Log Message: > Import on vendor branch two files that have been tweaked to unbreak > the build. The openbsm folks are free to fix it in any other way they > see fit once they resurface. > > Basically, make everything always be const char **, even though const > char ** usually should be 'const char * const *' in most cases. This > makes the three different definitions consistant and allows world to > build. The audit_record.h file in src/contrib/openbsm/bsm is not used in building FreeBSD; instead, src/sys/bsm is used. If audit_record.h is being used from the contrib tree, there is a problem with the build parts. Looking at the BSD makefiles associated with libbsm, I'm not sure I see how that can happen. Notice that world builds on all platforms but amd64, and that the build failure is not an amd64-specific warning/error in the compile: it has to do with matching prototypes, not with pointer/int size, format strings, etc. I'm not convinced OpenBSM is at fault here, although clearly it's triggered by the OpenBSM import. Robert N M Watson Computer Laboratory University of Cambridge