From owner-svn-src-head@FreeBSD.ORG Fri Oct 17 00:09:03 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E792130E; Fri, 17 Oct 2014 00:09:03 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 629633A7; Fri, 17 Oct 2014 00:09:03 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s9H08vjW089526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 17 Oct 2014 04:08:57 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s9H08vAR089525; Fri, 17 Oct 2014 04:08:57 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 17 Oct 2014 04:08:57 +0400 From: Gleb Smirnoff To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys Message-ID: <20141017000857.GH73266@FreeBSD.org> References: <201410101926.s9AJQRY1049602@svn.freebsd.org> <20141015030455.GC73266@FreeBSD.org> <86wq81y9fz.fsf@nine.des.no> <20141016225955.GE73266@FreeBSD.org> <86wq7zwq1w.fsf@nine.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86wq7zwq1w.fsf@nine.des.no> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: src-committers , Ed Maste , svn-src-all , "George V. Neville-Neil" , Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= , svn-src-head X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Oct 2014 00:09:04 -0000 On Fri, Oct 17, 2014 at 01:30:35AM +0200, Dag-Erling Smørgrav wrote: D> Gleb Smirnoff writes: D> > The function should also be documented in hash(9). D> D> It's not intended as a "general kernel hashing function". It is D> intended solely for pf. Why? If so, it should live in pf and not compiled uncoditionally into all kernels. Anyway, I don't see reason for doing it non-generic. P.S. Once I gathered 3 jenkins hash copy-n-pastes into one place, and we still got an extra copy in ofed. -- Totus tuus, Glebius.