Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Sep 2019 14:08:15 -0000
From:      Bruce Evans <brde@optusnet.com.au>
To:        "Bjoern A. Zeeb" <bz@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r346554 - head/sys/netinet
Message-ID:  <20190423004413.E2402@besplex.bde.org>
In-Reply-To: <7A9D3668-2949-45CF-B5A2-968F633FE285@FreeBSD.org>
References:  <201904221420.x3MEKn34037421@repo.freebsd.org> <7A9D3668-2949-45CF-B5A2-968F633FE285@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 22 Apr 2019, Bjoern A. Zeeb wrote:

> On 22 Apr 2019, at 14:20, Bjoern A. Zeeb wrote:
>> Log:
>>   Remove some excessive brackets.
>> 
>>   No functional change.
>
> But it includes a stye bug; sorry; I had re-indented the lines to validate 
> the change.  I<UTF deleted>ll remedy this with the follow-up commit which will split 
> that block up anyway.

Also, it removes excessive parentheses, not excessive brackets.

I think excessive brackets are just syntax errors.  E.g., a[[i]].

Excessive braces are not syntax errors, but I've never more than single
excessive ones.  E.g.,

 	if (foo != 0) {
 		bar();
 	}

is a common style bug, but

 	if (foo != 0) {{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{
 		bar();
 	              }}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}}

s unusual.

Bruce





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190423004413.E2402>