Date: Thu, 19 Jul 2012 19:43:53 GMT From: Olli Hauer <ohauer@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/170005: [patch] ports-mgmt/pkg honor file:/// as valid url schema Message-ID: <201207191943.q6JJhrrF002331@freefall.freebsd.org> Resent-Message-ID: <201207191950.q6JJoC9X003115@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 170005
>Category: ports
>Synopsis: [patch] ports-mgmt/pkg honor file:/// as valid url schema
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jul 19 19:50:11 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Olli Hauer <ohauer@FreeBSD.org>
>Release:
>Organization:
>Environment:
>Description:
I share packages since ages via NFS but PACKAGESITE do not understand
a sipmple path as URL and also not file://$path.
This schema is at last usefull to update the packagebuilding machine
in case tinderbox without WEBUI.
Since libfetch does understand file:/// it will be nice if this schema
will be supported.
Additional the url check should be improved a littel bit so
not valid PACKAGESIE notations are detected.
saple set as packagesite:
- $path/to/repo
- file://$path/to/repo -> (use only // instead ///)
>How-To-Repeat:
>Fix:
--- pkg.diff begins here ---
Index: files/patch-pkg__add.c
===================================================================
--- files/patch-pkg__add.c (revision 0)
+++ files/patch-pkg__add.c (working copy)
@@ -0,0 +1,10 @@
+--- ./pkg/add.c.orig 2012-07-19 20:26:49.000000000 +0200
++++ ./pkg/add.c 2012-07-19 20:29:24.000000000 +0200
+@@ -44,6 +44,7 @@
+ {
+ if (strncmp(pattern, "http://", 7) == 0 ||
+ strncmp(pattern, "https://", 8) == 0 ||
++ strncmp(pattern, "file:///", 8) == 0 ||
+ strncmp(pattern, "ftp://", 6) == 0)
+ return (EPKG_OK);
+
--- pkg.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201207191943.q6JJhrrF002331>