From owner-cvs-ports@FreeBSD.ORG Thu Dec 9 14:39:30 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 29E5216A4CE; Thu, 9 Dec 2004 14:39:30 +0000 (GMT) Received: from obsecurity.dyndns.org (CPE0050040655c8-CM00111ae02aac.cpe.net.cable.rogers.com [69.194.102.143]) by mx1.FreeBSD.org (Postfix) with ESMTP id EEBF643D1D; Thu, 9 Dec 2004 14:39:29 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id E79CE512D1; Thu, 9 Dec 2004 06:46:02 -0800 (PST) Date: Thu, 9 Dec 2004 06:46:02 -0800 From: Kris Kennaway To: Michael Johnson Message-ID: <20041209144602.GA79516@xor.obsecurity.org> References: <200412090519.iB95Jmle030877@repoman.freebsd.org> <20041209054836.GA38715@xor.obsecurity.org> <5C5A847A-49A6-11D9-BAFE-000A958C81C6@ahze.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt" Content-Disposition: inline In-Reply-To: <5C5A847A-49A6-11D9-BAFE-000A958C81C6@ahze.net> User-Agent: Mutt/1.4.2.1i cc: cvs-ports@FreeBSD.org cc: ports-committers@FreeBSD.org cc: Michael Johnson cc: cvs-all@FreeBSD.org cc: Kris Kennaway Subject: Re: cvs commit: ports/www/kazehakase Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2004 14:39:30 -0000 --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 09, 2004 at 12:51:24AM -0500, Michael Johnson wrote: >=20 > On Dec 9, 2004, at 12:48 AM, Kris Kennaway wrote: >=20 > >On Thu, Dec 09, 2004 at 05:19:48AM +0000, Michael Johnson wrote: > >>ahze 2004-12-09 05:19:48 UTC > >> > >> FreeBSD ports repository > >> > >> Modified files: > >> www/kazehakase Makefile > >> Log: > >> - Convert OPTIONS to Knobs > > > >Isn't that a step backwards? What was wrong with it? >=20 > I did this for two reasons, WITH_MOZILLA can't be an option because it=20 > can be mozilla or mozilla-devel (and in the future it will have=20 > firefox) OK, so that's one of them that doesn't necessarily have to be an option. You could easily do it though: WITH_MOZILLA turns on mozilla, and if WITH_MOZILLA_DEVEL is also turned on then it uses mozilla-devel instead. > and there's some new OPTIONS I feel can't be explained well in the=20 > space limit of OPTIONS, and the only OPTION that was small enough > for OPTIONS is only for the Japanese language. You can always say "see Makefile for full explanation" and still use OPTIONS, so you get the benefits of things like the permanent configuration. Kris --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBuGUqWry0BWjoQKURAnXtAJ9vqYiKs3Qdjnlk/YLXBxe8VeaeQQCggEEw Z7ufV426InJQtoW+oA9FuI8= =tCSj -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt--