From owner-cvs-ports@FreeBSD.ORG Wed Jun 9 06:52:39 2010 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5C6D1065670; Wed, 9 Jun 2010 06:52:39 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from worf.ds9.tecnik93.com (worf.ds9.tecnik93.com [81.196.207.130]) by mx1.freebsd.org (Postfix) with ESMTP id 524EC8FC14; Wed, 9 Jun 2010 06:52:39 +0000 (UTC) Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by worf.ds9.tecnik93.com (Postfix) with ESMTPSA id D8DCA22C50CC; Wed, 9 Jun 2010 09:52:37 +0300 (EEST) Date: Wed, 9 Jun 2010 09:52:37 +0300 From: Ion-Mihai Tetcu To: Greg Lewis Message-ID: <20100609095237.3a463a2a@it.buh.tecnik93.com> In-Reply-To: <20100609063126.GA96306@misty.eyesbeyond.com> References: <201006082017.o58KHb1o039986@repoman.freebsd.org> <4C0EB5E8.5040009@p6m7g8.com> <20100609004757.7a61d6f6@it.buh.tecnik93.com> <20100609035149.GA94751@misty.eyesbeyond.com> <4C0F146C.3060906@p6m7g8.com> <20100609063126.GA96306@misty.eyesbeyond.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; amd64-portbld-freebsd8.1) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/KcGaw6q1WPFApk4Vs_Jp=0e"; protocol="application/pgp-signature" Cc: Rob Farmer , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, "Philip M. Gollucci" , cvs-ports@FreeBSD.org, glewis@FreeBSD.org Subject: Re: cvs commit: ports/java/jdk16 Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2010 06:52:39 -0000 --Sig_/KcGaw6q1WPFApk4Vs_Jp=0e Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 8 Jun 2010 23:31:26 -0700 Greg Lewis wrote: > On Wed, Jun 09, 2010 at 12:11:24AM -0400, Philip M. Gollucci wrote: > > On 6/8/2010 11:51 PM, Greg Lewis wrote: > > > The build uses the following logic to detect the presence of > > > sigignore: > > >=20 > > > ifeq ($(OS_VENDOR),FreeBSD) > > > OS_RELDATE :=3D $(shell sysctl kern.osreldate | cut -d' ' -f2) > > > HAS_SIGIGNORE :=3D $(shell if [ $(OS_RELDATE) -ge 800502 -a > > > $(OS_RELDATE) -lt 900000 -o $(OS_RELDATE) -ge 900003 ]; then echo > > > "1"; fi) ifeq ($(HAS_SIGIGNORE),1) override > > > HAVE_SIGIGNORE =3D true endif > > > endif > > >=20 > >=20 > > Why not do something like what devel/apr1 does: > >=20 > > patch the file to be %%OSVERSION%% here, then in post-patch replace > > that token with the value. OSVERSION is overloaded correctly on > > pointyhat and tb(hence QAT) whereas sysctl is not. > >=20 > >=20 > > post-patch: > > ${REINPLACE_CMD} -e 's/OSVERSION/${OSVERSION}/g' \ > > ${APR_WRKDIR}/build/apr_hints.m4 >=20 > Thanks. I've committed a change to do this. >=20 > If someone could please let me know if you see any problems (I don't > have a box which actually has a recent 8-STABLE or 9-CURRENT I can > test on) that would be great. It seems to still do the right thing > on versions without sigignore(3) at least. Thanks. > It would also be good to know if QAT is now happy with it. It's next in the queue, so you'll get a mail about it. --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/KcGaw6q1WPFApk4Vs_Jp=0e Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkwPOjUACgkQJ7GIuiH/oeVVkQCgiTRGUmRo+fd4tAbh0T/PryIS x6UAnjf+br1lRr5xYr4SFuJSFd0Fch4N =sqML -----END PGP SIGNATURE----- --Sig_/KcGaw6q1WPFApk4Vs_Jp=0e--